[NFC][SYCL] Prepare unittests/program_manager for getSyclObjImpl to return raw ref (#19220)

I'm planning to change `getSyclObjImpl` to return a raw reference in a
later patch, uploading a bunch of PRs in preparation to that to make the
subsequent review easier.

Author: aelovikov-intel

sycl/unittests/program_manager/BuildLog.cpp

@@ -63,9 +63,9 @@ TEST(BuildLog, OutputNothingOnLevel1) {
   sycl::context Ctx{Dev};
   sycl::queue Queue{Ctx, Dev};
 
-  auto ContextImpl = getSyclObjImpl(Ctx);
+  context_impl &ContextImpl = *getSyclObjImpl(Ctx);
   // Make sure no kernels are cached
-  ContextImpl->getKernelProgramCache().reset();
+  ContextImpl.getKernelProgramCache().reset();
 
   LogRequested = false;
   sycl::kernel_bundle KernelBundle =
@@ -90,9 +90,9 @@ TEST(BuildLog, OutputLogOnLevel2) {
   sycl::context Ctx{Dev};
   sycl::queue Queue{Ctx, Dev};
 
-  auto ContextImpl = getSyclObjImpl(Ctx);
+  context_impl &ContextImpl = *getSyclObjImpl(Ctx);
   // Make sure no kernels are cached
-  ContextImpl->getKernelProgramCache().reset();
+  ContextImpl.getKernelProgramCache().reset();
 
   LogRequested = false;
   sycl::kernel_bundle KernelBundle =

sycl/unittests/program_manager/DynamicLinking/DynamicLinking.cpp

@@ -399,14 +399,14 @@ TEST(DynamicLinking, KernelBundleMutualDepBuildIndirect) {
 }
 
 template <sycl::bundle_state State>
-std::shared_ptr<sycl::detail::device_image_impl>
+sycl::detail::device_image_impl &
 getImage(const sycl::kernel_bundle<State> &KernelBundle,
          const sycl::kernel_id &KernelID) {
   auto It =
       std::find_if(KernelBundle.begin(), KernelBundle.end(),
                    [&](auto Image) { return Image.has_kernel(KernelID); });
   EXPECT_NE(It, KernelBundle.end());
-  return sycl::detail::getSyclObjImpl(*It);
+  return *sycl::detail::getSyclObjImpl(*It);
 }
 
 template <sycl::bundle_state State>
@@ -418,16 +418,16 @@ void runSpecConstChecksUnlinked(
             20);
   // Kernel bundles store spec constant values even if they're not part of any
   // images, check image spec const blobs.
-  std::shared_ptr<sycl::detail::device_image_impl> ImgA =
+  sycl::detail::device_image_impl &ImgA =
       getImage(KernelBundle,
                sycl::get_kernel_id<DynamicLinkingTest::MutualDepKernelA>());
-  std::vector<unsigned char> &BlobA = ImgA->get_spec_const_blob_ref();
+  std::vector<unsigned char> &BlobA = ImgA.get_spec_const_blob_ref();
   int SpecConstVal1 = *reinterpret_cast<int *>(BlobA.data());
   EXPECT_EQ(SpecConstVal1, 10);
-  std::shared_ptr<sycl::detail::device_image_impl> ImgB =
+  sycl::detail::device_image_impl &ImgB =
       getImage(KernelBundle,
                sycl::get_kernel_id<DynamicLinkingTest::MutualDepKernelB>());
-  std::vector<unsigned char> &BlobB = ImgB->get_spec_const_blob_ref();
+  std::vector<unsigned char> &BlobB = ImgB.get_spec_const_blob_ref();
   int SpecConstVal2 = *reinterpret_cast<int *>(BlobB.data());
   EXPECT_EQ(SpecConstVal2, 20);
 }
@@ -438,16 +438,16 @@ void runSpecConstChecksLinked(
   EXPECT_EQ(KernelBundle.get_specialization_constant<SpecConst2>(), 20);
   // Kernel bundles store spec constant values even if they're not part of any
   // images, check image spec const blobs.
-  std::shared_ptr<sycl::detail::device_image_impl> ImgA =
+  sycl::detail::device_image_impl &ImgA =
       getImage(KernelBundle,
                sycl::get_kernel_id<DynamicLinkingTest::MutualDepKernelA>());
-  std::shared_ptr<sycl::detail::device_image_impl> ImgB =
+  sycl::detail::device_image_impl &ImgB =
       getImage(KernelBundle,
                sycl::get_kernel_id<DynamicLinkingTest::MutualDepKernelB>());
-  EXPECT_EQ(ImgA, ImgB);
-  const std::vector<unsigned char> &Blob = ImgA->get_spec_const_blob_ref();
+  EXPECT_EQ(&ImgA, &ImgB);
+  const std::vector<unsigned char> &Blob = ImgA.get_spec_const_blob_ref();
   const sycl::detail::device_image_impl::SpecConstMapT &SpecConstMap =
-      ImgA->get_spec_const_data_ref();
+      ImgA.get_spec_const_data_ref();
 
   auto It = SpecConstMap.find("SC1");
   ASSERT_NE(It, SpecConstMap.end());

sycl/unittests/program_manager/arg_mask/EliminatedArgMask.cpp

@@ -165,13 +165,13 @@ class MockHandler : public sycl::handler {
 
 const sycl::detail::KernelArgMask *getKernelArgMaskFromBundle(
     const sycl::kernel_bundle<sycl::bundle_state::input> &KernelBundle,
-    std::shared_ptr<sycl::detail::queue_impl> QueueImpl) {
+    sycl::detail::queue_impl &QueueImpl) {
 
   auto ExecBundle = sycl::link(sycl::compile(KernelBundle));
   EXPECT_FALSE(ExecBundle.empty()) << "Expect non-empty exec kernel bundle";
 
   // Emulating processing of command group function
-  MockHandler MockCGH(*QueueImpl);
+  MockHandler MockCGH(QueueImpl);
   MockCGH.use_kernel_bundle(ExecBundle);
   MockCGH.single_task<EAMTestKernel>([] {}); // Actual kernel does not matter
 
@@ -218,7 +218,7 @@ TEST(EliminatedArgMask, KernelBundleWith2Kernels) {
 
   const sycl::detail::KernelArgMask *EliminatedArgMask =
       getKernelArgMaskFromBundle(KernelBundle,
-                                 sycl::detail::getSyclObjImpl(Queue));
+                                 *sycl::detail::getSyclObjImpl(Queue));
   assert(EliminatedArgMask && "EliminatedArgMask must be not null");
 
   sycl::detail::KernelArgMask ExpElimArgMask(EAMTestKernelNumArgs);