Skip to content

Commit c254acc

Browse files
authored
Added --verbose in the proper place in compile.py (#20825)
When running `compile.py` (after `configure.py`) with the `--verbose` flag, the resulting cmake command is `cmake --build build <my_build_dir> -- deply-sycl-toolchain --verbose` which results in an error like this `/usr/bin/gmake: unrecognized option '--verbose'` when using Unix Makefiles as generator. To support both makefiles and ninja, a better and easier approach is to just place `--verbose` before the `--` in the final command.
1 parent 80da6b6 commit c254acc

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

buildbot/compile.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,15 +31,18 @@ def do_compile(args):
3131
"cmake",
3232
"--build",
3333
abs_obj_dir,
34+
]
35+
36+
if args.verbose:
37+
cmake_cmd.append("--verbose")
38+
39+
cmake_cmd += [
3440
"--",
3541
args.build_target,
3642
"-j",
3743
str(cpu_count),
3844
]
3945

40-
if args.verbose:
41-
cmake_cmd.append("--verbose")
42-
4346
print("[Cmake Command]: {}".format(" ".join(cmake_cmd)))
4447

4548
subprocess.check_call(cmake_cmd, cwd=abs_obj_dir)

0 commit comments

Comments
 (0)