Skip to content

Commit c309c69

Browse files
[SYCL][E2E] Don't cover full combinations in vec_binary_scalar_order* (#16574)
First, full coverage belongs to CTS, not to unit tests. Second, implementation is heavily templated and there isn't much differences potential for many intger types or vector sizes. This PR eliminates test cases that are unlikely to excercise the code not covered by the remaining ones. The purpose of this is to reduce the time these tests takes as they're very close to be a bottleneck on machines with lots of cores where total wall clock time is defined by the longest tests in the suite.
1 parent 7835506 commit c309c69

File tree

5 files changed

+3
-31
lines changed

5 files changed

+3
-31
lines changed

sycl/test-e2e/Basic/vector/vec_binary_scalar_order.hpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,5 @@ bool CheckResult(sycl::vec<T1, N> V, T2 Ref) {
9393

9494
#define CHECK_SIZES(Q, C, T, IS_RELOP, OP) \
9595
CHECK(Q, C, T, 1, IS_RELOP, OP) \
96-
CHECK(Q, C, T, 2, IS_RELOP, OP) \
97-
CHECK(Q, C, T, 4, IS_RELOP, OP) \
98-
CHECK(Q, C, T, 8, IS_RELOP, OP) \
99-
CHECK(Q, C, T, 16, IS_RELOP, OP)
96+
CHECK(Q, C, T, 3, IS_RELOP, OP) \
97+
CHECK(Q, C, T, 8, IS_RELOP, OP)

sycl/test-e2e/Basic/vector/vec_binary_scalar_order_arith.cpp

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,25 +26,13 @@ int main() {
2626
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, double);
2727
}
2828

29-
// Check all operators without requirements.
29+
// Check operators without requirements.
3030
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, float);
3131
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, int8_t);
32-
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, int16_t);
33-
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, int32_t);
34-
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, int64_t);
35-
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, uint8_t);
3632
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, uint16_t);
37-
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, uint32_t);
38-
CHECK_SIZES_AND_COMMON_OPS(Q, Failures, uint64_t);
3933

4034
// Check integer only operators.
41-
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, int8_t);
4235
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, int16_t);
43-
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, int32_t);
44-
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, int64_t);
4536
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, uint8_t);
46-
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, uint16_t);
47-
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, uint32_t);
48-
CHECK_SIZES_AND_INT_ONLY_OPS(Q, Failures, uint64_t);
4937
return Failures;
5038
}

sycl/test-e2e/Basic/vector/vec_binary_scalar_order_bitwise.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,12 +19,7 @@ int main() {
1919

2020
// Check operators.
2121
CHECK_SIZES_AND_OPS(Q, Failures, int8_t);
22-
CHECK_SIZES_AND_OPS(Q, Failures, int16_t);
2322
CHECK_SIZES_AND_OPS(Q, Failures, int32_t);
24-
CHECK_SIZES_AND_OPS(Q, Failures, int64_t);
25-
CHECK_SIZES_AND_OPS(Q, Failures, uint8_t);
2623
CHECK_SIZES_AND_OPS(Q, Failures, uint16_t);
27-
CHECK_SIZES_AND_OPS(Q, Failures, uint32_t);
28-
CHECK_SIZES_AND_OPS(Q, Failures, uint64_t);
2924
return Failures;
3025
}

sycl/test-e2e/Basic/vector/vec_binary_scalar_order_logical.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,7 @@ int main() {
2424
// Check all operators without requirements.
2525
CHECK_SIZES_AND_OPS(Q, Failures, float);
2626
CHECK_SIZES_AND_OPS(Q, Failures, int8_t);
27-
CHECK_SIZES_AND_OPS(Q, Failures, int16_t);
2827
CHECK_SIZES_AND_OPS(Q, Failures, int32_t);
29-
CHECK_SIZES_AND_OPS(Q, Failures, int64_t);
30-
CHECK_SIZES_AND_OPS(Q, Failures, uint8_t);
3128
CHECK_SIZES_AND_OPS(Q, Failures, uint16_t);
32-
CHECK_SIZES_AND_OPS(Q, Failures, uint32_t);
33-
CHECK_SIZES_AND_OPS(Q, Failures, uint64_t);
3429
return Failures;
3530
}

sycl/test-e2e/Basic/vector/vec_binary_scalar_order_relational.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,8 @@ int main() {
2929
// Check all operators without requirements.
3030
CHECK_SIZES_AND_OPS(Q, Failures, float);
3131
CHECK_SIZES_AND_OPS(Q, Failures, int8_t);
32-
CHECK_SIZES_AND_OPS(Q, Failures, int16_t);
3332
CHECK_SIZES_AND_OPS(Q, Failures, int32_t);
34-
CHECK_SIZES_AND_OPS(Q, Failures, int64_t);
3533
CHECK_SIZES_AND_OPS(Q, Failures, uint8_t);
3634
CHECK_SIZES_AND_OPS(Q, Failures, uint16_t);
37-
CHECK_SIZES_AND_OPS(Q, Failures, uint32_t);
38-
CHECK_SIZES_AND_OPS(Q, Failures, uint64_t);
3935
return Failures;
4036
}

0 commit comments

Comments
 (0)