Skip to content

Commit c39e14f

Browse files
committed
Rewrite tests to use std::array instead of heap
Signed-off-by: John Pennycook <[email protected]>
1 parent 56c149c commit c39e14f

File tree

2 files changed

+9
-11
lines changed

2 files changed

+9
-11
lines changed

sycl/test-e2e/Reduction/reduction_deterministic.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %{build} -o %t.out
22
// RUN: %{run} %t.out
33

4+
#include <array>
45
#include <cstdio>
56
#include <cstdlib>
67
#include <random>
@@ -31,19 +32,17 @@ float sum(sycl::queue q, float *array, size_t N) {
3132
int main(int argc, char *argv[]) {
3233

3334
constexpr size_t N = 1024;
34-
float *array = new float[N];
35+
std::array<float, N> array;
3536

3637
std::random_device rd;
3738
std::mt19937 gen(rd());
3839
std::uniform_real_distribution<float> dist(0.0f, 1.0f);
39-
std::generate(array, array + N, [&]() { return dist(gen); });
40+
std::generate(array.begin(), array.end(), [&]() { return dist(gen); });
4041

4142
sycl::queue q;
42-
float x = sum(q, array, N);
43-
float y = sum(q, array, N);
43+
float x = sum(q, array.data(), N);
44+
float y = sum(q, array.data(), N);
4445

4546
// NB: determinism guarantees bitwise reproducible reductions for floats
4647
assert(sycl::bit_cast<unsigned int>(x) == sycl::bit_cast<unsigned int>(y));
47-
48-
delete[] array;
4948
}

sycl/test-e2e/Reduction/reduction_initialize_to_identity.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %{build} -o %t.out
22
// RUN: %{run} %t.out
33

4+
#include <array>
45
#include <cstdio>
56
#include <cstdlib>
67
#include <numeric>
@@ -32,12 +33,10 @@ int sum(sycl::queue q, int *array, size_t N) {
3233
int main(int argc, char *argv[]) {
3334

3435
constexpr size_t N = 32;
35-
int *array = new int[N];
36-
std::iota(array, array + N, 1);
36+
std::array<int, N> array;
37+
std::iota(array.begin(), array.end(), 1);
3738

3839
sycl::queue q;
39-
int x = sum(q, array, N);
40+
int x = sum(q, array.data(), N);
4041
assert(x == 528);
41-
42-
delete[] array;
4342
}

0 commit comments

Comments
 (0)