Skip to content

Commit c4c7004

Browse files
committed
Remove dg1; Update doc
1 parent b3e2137 commit c4c7004

File tree

2 files changed

+17
-24
lines changed

2 files changed

+17
-24
lines changed

sycl/test-e2e/README.md

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,10 @@ environment:
232232
* **aspect-\<name\>**: - SYCL aspects supported by a device;
233233
* **arch-\<name\>** - [SYCL architecture](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_device_architecture.asciidoc) of a device (e.g. `arch-intel_gpu_pvc`, the name matches what you
234234
can pass into `-fsycl-targets` compiler flag);
235+
* **gpu-intel-dg2** - Intel GPU DG2 availability; Automatically set if device
236+
architecture belongs to DG2 family;
237+
* **gpu-intel-gen11** - Intel GPU Gen11 availability; Automatically set if device architecture belongs to Gen11 family;
238+
* **gpu-intel-gen12** - Intel GPU DG2 availability; Automatically set if device architecture belongs to Gen12 family;
235239

236240
### Manually-set features
237241

@@ -240,18 +244,10 @@ section below). All these features are related to HW detection and they should
240244
be considered deprecated, because we have HW auto-detection functionality in
241245
place. No new tests should use these features:
242246

243-
* **gpu-intel-gen11** - Intel GPU Gen11 availability;
244-
* **gpu-intel-gen12** - Intel GPU Gen12 availability;
245247
* **gpu-intel-dg1** - Intel GPU DG1 availability;
246-
* **gpu-intel-dg2** - Intel GPU DG2 availability;
247248
* **gpu-intel-pvc** - Intel GPU PVC availability;
248249
* **gpu-intel-pvc-vg** - Intel GPU PVC-VG availability;
249250

250-
Note: some of those features describing whole GPU families and auto-detection
251-
of HW does not provide this functionality at the moment. As an improvement, we
252-
could add those features even with auto-detection, because the only alternative
253-
at the moment is to explicitly list every architecture from a family.
254-
255251
## llvm-lit parameters
256252

257253
Following options can be passed to llvm-lit tool through --param option to

sycl/test-e2e/lit.cfg.py

Lines changed: 13 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,9 @@
173173
if lit_config.params.get("igc-dev", False):
174174
config.available_features.add("igc-dev")
175175

176-
# Map between architecture types and device name.
177-
device_name_arch_map = {
178-
# <Device name> : Set of architectures types (and aliases)
179-
# DG1
180-
"gpu-intel-dg1": {"intel_gpu_dg1"},
176+
# Map between device family and architecture types.
177+
device_family_arch_map = {
178+
# <Family name> : Set of architectures types (and aliases)
181179
# DG2
182180
"gpu-intel-dg2": {
183181
"intel_gpu_acm_g12",
@@ -193,11 +191,10 @@
193191
"gpu-intel-gen11": {"intel_gpu_icllp", "intel_gpu_icl"},
194192
}
195193

196-
197-
def get_device_name_from_arch(arch):
198-
for device_name, arch_set in device_name_arch_map.items():
194+
def get_device_family_from_arch(arch):
195+
for device_family, arch_set in device_family_arch_map.items():
199196
if arch in arch_set:
200-
return device_name
197+
return device_family
201198
return None
202199

203200
def check_igc_tag_and_add_feature():
@@ -795,27 +792,27 @@ def open_check_file(file_name):
795792
aspect_features = set("aspect-" + a for a in aspects)
796793
sg_size_features = set("sg-" + s for s in sg_sizes)
797794
architecture_feature = set("arch-" + s for s in architectures)
798-
# Add device name features like intel-gpu-gen12, intel-gpu-dg2 based on
795+
# Add device family features like intel-gpu-gen12, intel-gpu-dg2 based on
799796
# the architecture reported by sycl-ls.
800-
device_names = set(
801-
get_device_name_from_arch(arch)
797+
device_family = set(
798+
get_device_family_from_arch(arch)
802799
for arch in architectures
803-
if get_device_name_from_arch(arch) is not None
800+
if get_device_family_from_arch(arch) is not None
804801
)
805802

806803
# Print the detected GPU family name.
807-
if len(device_names) > 0:
804+
if len(device_family) > 0:
808805
lit_config.note(
809806
"Detected GPU family for {}: {}".format(
810-
sycl_device, ", ".join(device_names)
807+
sycl_device, ", ".join(device_family)
811808
)
812809
)
813810

814811
features = set()
815812
features.update(aspect_features)
816813
features.update(sg_size_features)
817814
features.update(architecture_feature)
818-
features.update(device_names)
815+
features.update(device_family)
819816

820817
be, dev = sycl_device.split(":")
821818
features.add(dev.replace("fpga", "accelerator"))

0 commit comments

Comments
 (0)