You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[libclc] Let builtins_remangle_path generating command depend on prepare-${obj_suffix} target (#19619)
The add_custom_command depends on builtins_lib, but not on
prepare-${obj_suffix} target that generates builtins_lib. cmake
documentation doesn't mention that the add_custom_command will
automatically depends on prepare-${obj_suffix} target.
The dependency was removed in f07c1fa. However, our downstream repo
reintroduced it to fix build error in CMPLRLLVM-57824, where
builtins_lib is used while still being generated.
This PR adds the dependency back. Then, cmake will create a target-level
dependency to make sure prepare-${obj_suffix} target is built before
target
"remangled-${long_width}-${signedness}_char.${obj_suffix_mangled}".
0 commit comments