Skip to content

Commit c908d65

Browse files
committed
Require full issue URL instead of shortcut; Allow to use internal tracker IDs
1 parent 8da85a5 commit c908d65

File tree

4 files changed

+15
-5
lines changed

4 files changed

+15
-5
lines changed

sycl/test-e2e/README.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,11 @@ Once the issue is created, you can update the test by adding `XFAIL` and
335335
```
336336
// GPU driver update caused failure
337337
// XFAIL: level_zero
338-
// XFAIL-TRACKER: intel/llvm#DDDDD
338+
// XFAIL-TRACKER: PRJ-5324
339+
340+
// Sporadically fails on CPU:
341+
// XFAIL: cpu
342+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/DDDDD
339343
```
340344

341345
If you add `XFAIL` without `XFAIL-TRACKER` directive,

sycl/test-e2e/Sampler/normalized-clampedge-linear-float.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// RUN: %{build} -o %t.out
44
// RUN: %{run} %t.out
55
// XFAIL: hip
6-
// XFAIL-TRACKER: intel/llvm#14732
6+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14732
77

88
// CUDA works with image_channel_type::fp32, but not with any 8-bit per channel
99
// type (such as unorm_int8)

sycl/test-e2e/Sampler/normalized-clampedge-nearest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
// Missing __spirv_ImageWrite, __spirv_SampledImage,
66
// __spirv_ImageSampleExplicitLod on AMD
77
// XFAIL: hip_amd
8-
// XFAIL-TRACKER: intel/llvm#14732
8+
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/14732
99

1010
/*
1111
This file sets up an image, initializes it with data,

sycl/test-e2e/no-xfail-without-tracker.cpp

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,13 @@
33
//
44
// The format we check is:
55
// XFAIL: lit,features
6-
// XFAIL-TRACKER: intel/llvm issue URL|intel/llvm#NNNNN shortcut
6+
// XFAIL-TRACKER: [GitHub issue URL|Internal tracker ID]
7+
//
8+
// GitHub issue URL format:
9+
// https://github.com/owner/repo/issues/12345
10+
//
11+
// Internal tracker ID format:
12+
// PROJECT-123456
713
//
814
// REQUIRES: linux
915
//
@@ -20,7 +26,7 @@
2026
// RUN: grep -rI "XFAIL:" %S -A 1 --include=*.c --include=*.cpp \
2127
// RUN: --no-group-separator | \
2228
// RUN: grep -v "XFAIL:" | \
23-
// RUN: grep -Pv "XFAIL-TRACKER:\s+.*intel/llvm.*\d+" | \
29+
// RUN: grep -Pv "XFAIL-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)" | \
2430
// RUN: wc -l | FileCheck %s --check-prefix NUMBER-OF-XFAIL-WITHOUT-TRACKER
2531
//
2632
// The number below is a number of tests which are *impropertly* XFAIL-ed, i.e.

0 commit comments

Comments
 (0)