Skip to content

Commit cac6098

Browse files
committed
[TEST] Test new runner
1 parent 41a107a commit cac6098

File tree

3 files changed

+20
-11
lines changed

3 files changed

+20
-11
lines changed

.github/workflows/sycl-ur-perf-benchmarking.yml

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: Run Benchmarks
22

33
on:
4+
pull_request:
5+
branches:
6+
- sycl
47
workflow_call:
58
inputs:
69
preset:
@@ -35,18 +38,21 @@ on:
3538
results, this will be the name used to refer results from the current
3639
run.
3740
required: false
38-
default: ''
41+
default: 'test_runner_46'
3942
upload_results:
4043
type: string # true/false: workflow_dispatch does not support booleans
4144
description: |
4245
Upload results to https://intel.github.io/llvm/benchmarks/.
43-
required: true
46+
required: false
47+
default: 'true'
4448
runner:
4549
type: string
46-
required: true
50+
required: false
51+
default: '["test-runner"]'
4752
backend:
4853
type: string
49-
required: true
54+
required: false
55+
default: 'level_zero_v2:gpu'
5056

5157
workflow_dispatch:
5258
inputs:
@@ -93,14 +99,17 @@ on:
9399
runner:
94100
type: choice
95101
options:
102+
- '["test-runner"]'
96103
- '["PVC_PERF"]'
97104
- '["BMG_PERF"]'
105+
default: '["test-runner"]'
98106
backend:
99107
description: Backend to use
100108
type: choice
101109
options:
102-
- 'level_zero:gpu'
103110
- 'level_zero_v2:gpu'
111+
- 'level_zero:gpu'
112+
default: 'level_zero_v2:gpu'
104113
# As of #17407, sycl-linux-build now builds v2 by default
105114

106115
permissions: read-all
@@ -110,7 +119,7 @@ jobs:
110119
name: Sanitize inputs
111120
runs-on: ubuntu-latest
112121
env:
113-
COMMIT_HASH: ${{ inputs.commit_hash }}
122+
COMMIT_HASH: ${{ inputs.commit_hash || }}
114123
PR_NO: ${{ inputs.pr_no }}
115124
SAVE_NAME: ${{ inputs.save_name }}
116125
outputs:
@@ -178,12 +187,12 @@ jobs:
178187
matrix:
179188
include:
180189
# Set default values if not specified:
181-
- runner: ${{ inputs.runner || '["PVC_PERF"]' }}
182-
backend: ${{ inputs.backend || 'level_zero:gpu' }}
190+
- runner: ${{ inputs.runner || '["test-runner"]' }}
191+
backend: ${{ inputs.backend || 'level_zero_v2:gpu' }}
183192
uses: ./.github/workflows/sycl-linux-run-tests.yml
184193
secrets: inherit
185194
with:
186-
name: Run compute-benchmarks (${{ matrix.save_name }}, ${{ matrix.runner }}, ${{ matrix.backend }})
195+
name: Run compute-benchmarks (${{ needs.sanitize_inputs.outputs.benchmark_save_name }}, ${{ matrix.runner }}, ${{ matrix.backend }})
187196
runner: ${{ matrix.runner }}
188197
image: ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest
189198
image_options: -u 1001 --device=/dev/dri -v /dev/dri/by-path:/dev/dri/by-path --privileged --cap-add SYS_ADMIN

devops/actions/run-tests/benchmark/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ runs:
172172
esac
173173
case "$RUNNER_TAG" in
174174
'["PVC_PERF"]') MACHINE_TYPE="PVC" ;;
175-
'["BMG_PERF"]') MACHINE_TYPE="BMG" ;;
175+
'["test-runner2"]') MACHINE_TYPE="BMG" ;;
176176
# Best effort at matching
177177
*)
178178
MACHINE_TYPE="${RUNNER_TAG#[\"}"

devops/scripts/benchmarks/utils/validate.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def runner_name(runner_name: str, throw: Exception = None):
2727
"""
2828
Returns True if runner_name is clean (no illegal characters).
2929
"""
30-
return Validate.on_re(runner_name, r"^[a-zA-Z0-9_]+$", throw=throw)
30+
return Validate.on_re(runner_name, r"^[a-zA-Z0-9_-]+$", throw=throw)
3131

3232
@staticmethod
3333
def timestamp(t: str, throw: Exception = None):

0 commit comments

Comments
 (0)