Skip to content

Commit cc9e26e

Browse files
pbalcerianayl
authored andcommitted
[benchmarks] improve HTML and Markdown output
This patch improves numerous aspects on how the benchmarking results are visualized: - rewrites the way HTML charts are generated, using a library (Chart.js) that's both easier to use and more visually pleasing. The new HTML page also now decouples data from the HTML itself, leading to faster load times and the ability to fetch data from remote sources. - The markdown output now contains a failures section that lists all benchmarks that failed for a given run. This will be a helpful for developers during PR testing. - Benchmarks can now have description that's displayed on the page. - And many more minor improvements.
1 parent 0b3914b commit cc9e26e

File tree

19 files changed

+1311
-708
lines changed

19 files changed

+1311
-708
lines changed

devops/scripts/benchmarks/benches/base.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
import os
77
import shutil
88
from pathlib import Path
9-
from .result import Result
9+
from utils.result import Result
1010
from options import options
1111
from utils.utils import download, run
1212
import urllib.request
@@ -55,16 +55,25 @@ def create_data_path(self, name, skip_data_dir=False):
5555
data_path = os.path.join(self.directory, name)
5656
else:
5757
data_path = os.path.join(self.directory, "data", name)
58-
if options.rebuild and Path(data_path).exists():
58+
if options.redownload and Path(data_path).exists():
5959
shutil.rmtree(data_path)
6060

6161
Path(data_path).mkdir(parents=True, exist_ok=True)
6262

6363
return data_path
6464

65-
def download(self, name, url, file, untar=False, unzip=False, skip_data_dir=False):
65+
def download(
66+
self,
67+
name,
68+
url,
69+
file,
70+
untar=False,
71+
unzip=False,
72+
skip_data_dir=False,
73+
checksum="",
74+
):
6675
self.data_path = self.create_data_path(name, skip_data_dir)
67-
return download(self.data_path, url, file, untar, unzip)
76+
return download(self.data_path, url, file, untar, unzip, checksum)
6877

6978
def name(self):
7079
raise NotImplementedError()

0 commit comments

Comments
 (0)