[lldb] Disable PipeTest.OpenAsReader on windows

labath · labath · commit d36e879c21c9 · 2021-01-11T13:37:49.000+01:00
This test seems to be broken there (which is not totally surprising as
this functionality was never used on windows). Disable the test while I
investigate.
diff --git a/lldb/unittests/Host/PipeTest.cpp b/lldb/unittests/Host/PipeTest.cpp
@@ -29,6 +29,8 @@ TEST_F(PipeTest, CreateWithUniqueName) {
                     llvm::Succeeded());
 }
 
+// Test broken
+#ifndef _WIN32
 TEST_F(PipeTest, OpenAsReader) {
   Pipe pipe;
   llvm::SmallString<0> name;
@@ -46,3 +48,4 @@ TEST_F(PipeTest, OpenAsReader) {
       pipe.OpenAsReader(name_ref, /*child_process_inherit=*/false).ToError(),
       llvm::Succeeded());
 }
+#endif

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,8 @@ TEST_F(PipeTest, CreateWithUniqueName) {`
`29`	`29`	`llvm::Succeeded());`
`30`	`30`	`}`
`31`	`31`
	`32`	`+// Test broken`
	`33`	`+#ifndef _WIN32`
`32`	`34`	`TEST_F(PipeTest, OpenAsReader) {`
`33`	`35`	`Pipe pipe;`
`34`	`36`	`llvm::SmallString<0> name;`
`@@ -46,3 +48,4 @@ TEST_F(PipeTest, OpenAsReader) {`
`46`	`48`	`pipe.OpenAsReader(name_ref, /child_process_inherit=/false).ToError(),`
`47`	`49`	`llvm::Succeeded());`
`48`	`50`	`}`
	`51`	`+#endif`