Apply suggestions from code review

Co-authored-by: Alberto Cabrera Pérez <[email protected]>

Author: joeatodd

sycl/doc/syclcompat/README.md

@@ -61,7 +61,7 @@ If available, the following extensions extend SYCLcompat functionality:
 
 ### Hardware Requirements
 
-Some of the functionality provided by SYCLcompat relies on Unified Shared Memory (`aspect::usm_device_allocations`), though most of the USM-like memory APIs (malloc*, memcpy*, memset*) support hardware with only buffer/accessor support. See section [Buffer Support](#buffer-support) below.
+Some of the functionalities provided by SYCLcompat rely on Unified Shared Memory (`aspect::usm_device_allocations`), though most of the USM-like memory APIs (malloc*, memcpy*, memset*) support hardware with only buffer/accessor support. See section [Buffer Support](#buffer-support) below.
 
 ## Usage
 
@@ -847,6 +847,7 @@ public:
 
 } // syclcompat
 ```
+
 #### Buffer Support
 
 Although SYCLcompat is primarily designed around the Unified Shared Memory

sycl/include/syclcompat/memory.hpp

@@ -225,7 +225,7 @@ class mem_mgr {
     std::lock_guard<std::mutex> lock(m_mutex);
     if (next_free + size > mapped_address_space + mapped_region_size) {
       throw std::runtime_error(
-          "syclcompat malloc: out of memory for virtual memory pool");
+          "[SYCLcompat] malloc: out of memory for virtual memory pool");
     }
     // Allocation
     sycl::range<1> r(size);
@@ -284,14 +284,14 @@ class mem_mgr {
     auto it = m_map.upper_bound((byte_t *)ptr);
     if (it == m_map.end()) {
       // Not a virtual pointer.
-      throw std::runtime_error("can not get buffer from non-virtual pointer");
+      throw std::runtime_error("[SYCLcompat] can not get buffer from non-virtual pointer");
     }
     const allocation &alloc = it->second;
     if (ptr < alloc.alloc_ptr) {
       // Out of bound.
       // This may happen if there's a gap between allocations due to alignment
       // or extra padding and pointer points to this gap.
-      throw std::runtime_error("invalid virtual pointer");
+      throw std::runtime_error("[SYCLcompat] invalid virtual pointer");
     }
     return it;
   }
@@ -558,7 +558,7 @@ static sycl::event memcpy(sycl::queue q, void *to_ptr, const void *from_ptr,
     });
   }
   default:
-    throw std::runtime_error("syclcompat memcpy: invalid direction value");
+    throw std::runtime_error("[SYCLcompat] memcpy: invalid direction value");
   }
 #else
   return q.memcpy(to_ptr, from_ptr, size, dep_events);
@@ -778,7 +778,7 @@ static std::pair<buffer_t, size_t> get_buffer_and_offset(const void *ptr) {
     return std::make_pair(alloc.buffer, offset);
   } else {
     throw std::runtime_error(
-        "NULL pointer argument in get_buffer_and_offset function is invalid");
+        "[SYCLcompat] NULL pointer argument in get_buffer_and_offset function is invalid");
   }
 }
 
@@ -846,7 +846,7 @@ static sycl::accessor<byte_t, 1, accessMode> get_access(const void *ptr,
     return alloc.buffer.get_access<accessMode>(cgh);
   } else {
     throw std::runtime_error(
-        "NULL pointer argument in get_access function is invalid");
+        "[SYCLcompat] NULL pointer argument in get_access function is invalid");
   }
 }
 
@@ -1727,7 +1727,7 @@ class pointer_attributes {
   void init(const void *ptr, sycl::queue q = get_default_queue()) {
 #ifdef COMPAT_USM_LEVEL_NONE
     throw std::runtime_error(
-        "syclcompat::pointer_attributes: only works for USM pointer.");
+        "[SYCLcompat] pointer_attributes: only works for USM pointer.");
 #else
     memory_type = sycl::get_pointer_type(ptr, q.get_context());
     device_pointer = (memory_type != sycl::usm::alloc::unknown) ? ptr : nullptr;

sycl/test-e2e/syclcompat/memory/global_memory_usmnone.cpp

@@ -56,7 +56,7 @@ syclcompat::constant_memory<int, 1> c_1d(sycl::range<1>(15),
                                    {0, 10, 20, 30, 40, 50, 60, 70, 80, 90, 100,
                                     110, 120, 130, 140});
 
-bool verify_init(int *data) {  
+bool verify_init(int *data) {
   for(auto i = 0; i < 15; ++i) {
     if (data[i] != i * 10)
       return false;