You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[SYCL] Change the ext_intel_device_info spec to throw a feature not supported error when a query is not supported (#14576)
When an aspect is not supported by a device, the `ext_intel_device_info`
spec says to throw an invalid object runtime error when calling
`get_info` with the corresponding descriptor. This error description is
both vague and not very descriptive of the actual thing that went wrong,
namely that the query is simply not supported by a device. This PR
changes that to instead say to throw a feature not supported runtime
error.
---------
Co-authored-by: Greg Lueck <[email protected]>
Copy file name to clipboardExpand all lines: sycl/doc/extensions/supported/sycl_ext_intel_device_info.md
+13-13Lines changed: 13 additions & 13 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -46,7 +46,7 @@ A new aspect, ext\_intel\_device\_id, will be added.
46
46
47
47
## Error Condition ##
48
48
49
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_device\_id.
49
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_device_id`.
50
50
51
51
## Example Usage ##
52
52
@@ -83,7 +83,7 @@ A new aspect, ext\_intel\_device\_info\_uuid, will be added.
83
83
84
84
## Error Condition ##
85
85
86
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_device\_info\_uuid.
86
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_device_info_uuid`.
87
87
88
88
89
89
## Example Usage ##
@@ -123,7 +123,7 @@ A new aspect, ext\_intel\_pci\_address, will be added.
123
123
124
124
## Error Condition ##
125
125
126
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_pci\_address.
126
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_pci_address`.
127
127
128
128
129
129
## Example Usage ##
@@ -162,7 +162,7 @@ A new aspect, ext\_intel\_gpu\_eu\_simd\_width, will be added.
162
162
163
163
## Error Condition ##
164
164
165
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_simd\_width.
165
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_eu_simd_width`.
166
166
167
167
## Example Usage ##
168
168
@@ -202,7 +202,7 @@ A new aspect, ext\_intel\_gpu\_eu\_count, will be added.
202
202
203
203
## Error Condition ##
204
204
205
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count.
205
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_eu_count`.
206
206
207
207
## Example Usage ##
208
208
@@ -238,7 +238,7 @@ A new aspect, ext\_intel\_gpu\_slices, will be added.
238
238
239
239
## Error Condition ##
240
240
241
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_slices.
241
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_slices`.
242
242
243
243
## Example Usage ##
244
244
@@ -273,7 +273,7 @@ A new aspect, ext\_intel\_gpu\_subslices\_per\_slice, will be added.
273
273
274
274
## Error Condition ##
275
275
276
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_subslices\_per\_slice.
276
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_subslices_per_slice`.
277
277
278
278
## Example Usage ##
279
279
@@ -308,7 +308,7 @@ A new aspect, ext\_intel\_gpu\_eu\_count\_per\_subslice, will be added.
308
308
309
309
## Error Condition ##
310
310
311
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_eu\_count\_per\_subslice.
311
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_eu_count_per_subslice`.
312
312
313
313
## Example Usage ##
314
314
@@ -341,7 +341,7 @@ A new aspect, ext\_intel\_gpu\_hw\_threads\_per\_eu, will be added.
341
341
342
342
## Error Condition ##
343
343
344
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_gpu\_hw\_threads\_per\_eu.
344
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_gpu_hw_threads_per_eu`.
345
345
346
346
## Example Usage ##
347
347
@@ -377,7 +377,7 @@ A new aspect, ext\_intel\_max\_mem\_bandwidth, will be added.
377
377
378
378
## Error Condition ##
379
379
380
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_max\_mem\_bandwidth.
380
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_max_mem_bandwidth`.
381
381
382
382
383
383
## Example Usage ##
@@ -415,7 +415,7 @@ A new aspect, ext\_intel\_free\_memory, will be added.
415
415
416
416
## Error Condition ##
417
417
418
-
An invalid object runtime error will be thrown if the device does not support aspect\:\:ext\_intel\_free\_memory.
418
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_free_memory`.
419
419
420
420
421
421
## Example Usage ##
@@ -452,7 +452,7 @@ A new aspect, ext\_intel\_memory\_clock\_rate, is added.
452
452
453
453
## Error Condition ##
454
454
455
-
An invalid object runtime error is thrown if the device does not support aspect\:\:ext\_intel\_memory\_clock\_rate.
455
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_memory_clock_rate`.
456
456
457
457
458
458
## Example Usage ##
@@ -489,7 +489,7 @@ A new aspect, ext\_intel\_memory\_bus\_width, is added.
489
489
490
490
## Error Condition ##
491
491
492
-
An invalid object runtime error is thrown if the device does not support aspect\:\:ext\_intel\_memory\_bus\_width.
492
+
Throws a synchronous `exception` with the `errc::feature_not_supported` error code if the device does not have `aspect::ext_intel_memory_bus_width`.
0 commit comments