Skip to content

Commit d4893f7

Browse files
authored
Revert "[SYCL][E2E] Fix lit for arch selection and l0v2 adapter" (#20799)
Reverts #20728
1 parent 237242d commit d4893f7

File tree

5 files changed

+6
-55
lines changed

5 files changed

+6
-55
lines changed

sycl/test-e2e/AddressSanitizer/lit.local.cfg

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,5 +31,4 @@ unsupported_san_flags = [
3131
if any(flag in config.cxx_flags for flag in unsupported_san_flags):
3232
config.unsupported=True
3333

34-
if config.ze_affinity_mask is not None:
35-
config.environment["ZE_AFFINITY_MASK"] = config.ze_affinity_mask
34+
config.environment["ZE_AFFINITY_MASK"] = "0"

sycl/test-e2e/MemorySanitizer/lit.local.cfg

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,4 @@ unsupported_san_flags = [
3939
if any(flag in config.cxx_flags for flag in unsupported_san_flags):
4040
config.unsupported=True
4141

42-
if config.ze_affinity_mask is not None:
43-
config.environment["ZE_AFFINITY_MASK"] = config.ze_affinity_mask
42+
config.environment["ZE_AFFINITY_MASK"] = "0"

sycl/test-e2e/ThreadSanitizer/lit.local.cfg

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,5 +34,4 @@ unsupported_san_flags = [
3434
if any(flag in config.cxx_flags for flag in unsupported_san_flags):
3535
config.unsupported=True
3636

37-
if config.ze_affinity_mask is not None:
38-
config.environment["ZE_AFFINITY_MASK"] = config.ze_affinity_mask
37+
config.environment["ZE_AFFINITY_MASK"] = "0"

sycl/test-e2e/format.py

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -283,15 +283,6 @@ def get_extra_env(sycl_devices):
283283
# so that device might still be accessible to some of the tests yet
284284
# we won't set the environment variable below for such scenario.
285285
extra_env = []
286-
287-
# Include ZE_AFFINITY_MASK if set by lit.local.cfg (e.g., for sanitizer tests)
288-
if "ZE_AFFINITY_MASK" in test.config.environment:
289-
extra_env.append(
290-
"ZE_AFFINITY_MASK={}".format(
291-
test.config.environment["ZE_AFFINITY_MASK"]
292-
)
293-
)
294-
295286
if "level_zero:gpu" in sycl_devices and litConfig.params.get("ur_l0_debug"):
296287
extra_env.append("UR_L0_DEBUG={}".format(test.config.ur_l0_debug))
297288

@@ -351,14 +342,8 @@ def get_extra_env(sycl_devices):
351342
elif "level_zero_v1" in full_dev_name:
352343
expanded += " env UR_LOADER_USE_LEVEL_ZERO_V2=0"
353344

354-
# If ZE_AFFINITY_MASK is set in local config, it filters devices so we should use :0
355-
device_selector = parsed_dev_name
356-
if test.config.ze_affinity_mask is not None:
357-
backend, _ = parsed_dev_name.split(":", 1)
358-
device_selector = f"{backend}:0"
359-
360345
expanded += " ONEAPI_DEVICE_SELECTOR={} {}".format(
361-
device_selector, test.config.run_launcher
346+
parsed_dev_name, test.config.run_launcher
362347
)
363348
cmd = directive.command.replace("%{run}", expanded)
364349
# Expand device-specific condtions (%if ... %{ ... %}).
@@ -368,11 +353,6 @@ def get_extra_env(sycl_devices):
368353
"linux",
369354
"windows",
370355
"preview-breaking-changes-supported",
371-
# the following entries are used by architecture-based filtering
372-
# (:arch- device, not :gpu or :cpu)
373-
"cpu",
374-
"gpu",
375-
"accelerator",
376356
]:
377357
if cond_features in test.config.available_features:
378358
conditions[cond_features] = True

sycl/test-e2e/lit.cfg.py

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@
9696
"LIBCLANG_NOTHREADS",
9797
"LIBCLANG_RESOURCE_USAGE",
9898
"LIBCLANG_CODE_COMPLETION_LOGGING",
99-
"ZE_AFFINITY_MASK",
10099
]
101100

102101
# Names of the Release and Debug versions of the XPTIFW library
@@ -918,14 +917,12 @@ def get_sycl_ls_verbose(sycl_device, env):
918917

919918
env = copy.copy(llvm_config.config.environment)
920919

921-
backend_for_selector = backend.replace("_v2", "").replace("_v1", "")
922-
923920
# Find all available devices under the backend
924-
env["ONEAPI_DEVICE_SELECTOR"] = backend_for_selector + ":*"
921+
env["ONEAPI_DEVICE_SELECTOR"] = backend + ":*"
925922

926923
detected_architectures = []
927924

928-
platform_devices = backend_for_selector + ":*"
925+
platform_devices = remove_level_zero_suffix(backend + ":*")
929926

930927
for line in get_sycl_ls_verbose(platform_devices, env).stdout.splitlines():
931928
if re.match(r" *Architecture:", line):
@@ -951,15 +948,6 @@ def get_sycl_ls_verbose(sycl_device, env):
951948

952949
config.sycl_devices = filtered_sycl_devices
953950

954-
# Determine ZE_AFFINITY_MASK for Level Zero devices.
955-
# Sanitizer tests need to set ZE_AFFINITY_MASK to a single device index
956-
config.ze_affinity_mask = None
957-
for sycl_device in remove_level_zero_suffix(config.sycl_devices):
958-
be, dev = sycl_device.split(":")
959-
if be == "level_zero" and dev.isdigit():
960-
config.ze_affinity_mask = dev
961-
break
962-
963951
for sycl_device in remove_level_zero_suffix(config.sycl_devices):
964952
be, dev = sycl_device.split(":")
965953
config.available_features.add("any-device-is-" + dev)
@@ -1126,13 +1114,6 @@ def get_sycl_ls_verbose(sycl_device, env):
11261114
features.update(device_family)
11271115

11281116
be, dev = sycl_device.split(":")
1129-
if dev.isdigit():
1130-
backend_devices = available_devices.get(be, "gpu")
1131-
if isinstance(backend_devices, tuple):
1132-
# arch-selection is typically used to select gpu device
1133-
dev = "gpu"
1134-
else:
1135-
dev = backend_devices
11361117
features.add(dev.replace("fpga", "accelerator"))
11371118
if "level_zero_v2" in full_name:
11381119
features.add("level_zero_v2_adapter")
@@ -1165,13 +1146,6 @@ def get_sycl_ls_verbose(sycl_device, env):
11651146
else:
11661147
config.intel_driver_ver[full_name] = {}
11671148

1168-
# When running with a single device, merge device-specific features into global
1169-
# available_features so that %if conditionals work correctly, even if device is not :gpu or :cpu
1170-
if len(config.sycl_devices) == 1:
1171-
single_device = list(config.sycl_dev_features.keys())[0]
1172-
device_features = config.sycl_dev_features[single_device]
1173-
config.available_features.update(device_features)
1174-
11751149
if lit_config.params.get("compatibility_testing", "False") != "False":
11761150
config.substitutions.append(("%clangxx", " true "))
11771151
config.substitutions.append(("%clang", " true "))

0 commit comments

Comments
 (0)