Skip to content

Commit d4a7468

Browse files
committed
fix
Signed-off-by: Sidorov, Dmitry <[email protected]>
1 parent 4ad01f1 commit d4a7468

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

llvm/lib/SYCLLowerIR/SYCLSqrtFDivMaxErrorCleanUp.cpp

Lines changed: 7 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -54,31 +54,31 @@ SYCLSqrtFDivMaxErrorCleanUpPass::run(Module &M,
5454
// attribute, but it's not a concern of the pass, so just do an early
5555
// exit here if the attribute is not attached.
5656
if (!II->getAttributes().hasFnAttr("fpbuiltin-max-error"))
57-
return PreservedAnalyses::none();
57+
return PreservedAnalyses::all();
5858
StringRef MaxError = II->getAttributes().getFnAttr(
5959
"fpbuiltin-max-error").getValueAsString();
6060

6161
if (ID == llvm::Intrinsic::fpbuiltin_sqrt) {
6262
if (MaxError != SQRT_ERROR)
63-
return PreservedAnalyses::none();
63+
return PreservedAnalyses::all();
6464
WorkListSqrt.push_back(II);
6565
}
6666
else if (ID == llvm::Intrinsic::fpbuiltin_fdiv) {
6767
if (MaxError != FDIV_ERROR)
68-
return PreservedAnalyses::none();
68+
return PreservedAnalyses::all();
6969
WorkListFDiv.push_back(II);
7070
} else {
7171
// Another llvm.fpbuiltin.* intrinsic was found - the module is
7272
// already not backward compatible.
73-
return PreservedAnalyses::none();
73+
return PreservedAnalyses::all();
7474
}
7575
}
7676
}
7777
}
7878

7979
// No intrinsics at all - do an early exist.
8080
if (WorkListSqrt.empty() && WorkListFDiv.empty())
81-
return PreservedAnalyses::none();
81+
return PreservedAnalyses::all();
8282

8383
// If @sqrt, @_Z4sqrt*, @llvm.sqrt. or fdiv present in the module - do
8484
// nothing.
@@ -92,12 +92,12 @@ SYCLSqrtFDivMaxErrorCleanUpPass::run(Module &M,
9292
if (SqrtF->getName() == "sqrt" ||
9393
SqrtF->getName().starts_with("_Z4sqrt") ||
9494
SqrtF->getIntrinsicID() == llvm::Intrinsic::sqrt)
95-
return PreservedAnalyses::none();
95+
return PreservedAnalyses::all();
9696
}
9797
if (auto *FPI = dyn_cast<FPMathOperator>(&II)) {
9898
auto Opcode = FPI->getOpcode();
9999
if (Opcode == Instruction::FDiv)
100-
return PreservedAnalyses::none();
100+
return PreservedAnalyses::all();
101101
}
102102
}
103103
}
@@ -161,9 +161,5 @@ SYCLSqrtFDivMaxErrorCleanUpPass::run(Module &M,
161161
Decl->eraseFromParent();
162162
}
163163

164-
return PreservedAnalyses::none();
165-
if (InstsToRemove.empty())
166-
return PreservedAnalyses::none();
167-
168164
return PreservedAnalyses::all();
169165
}

0 commit comments

Comments
 (0)