Skip to content

Commit d9a4039

Browse files
committed
Defer barrier optimization path due to timestamp bugs
Signed-off-by: Larsen, Steffen <[email protected]>
1 parent 2b5e556 commit d9a4039

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

sycl/include/sycl/ext/oneapi/experimental/profiling_tag.hpp

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@ inline event submit_profiling_tag(queue &Queue,
2222
const sycl::detail::code_location &CodeLoc =
2323
sycl::detail::code_location::current()) {
2424
if (Queue.get_device().has(aspect::ext_oneapi_queue_profiling_tag)) {
25-
// If the queue is out-of-order and profiling is enabled, the implementation
26-
// can save some operations by just using the required barrier event
27-
// directly.
28-
if (!Queue.is_in_order() &&
29-
Queue.has_property<sycl::property::queue::enable_profiling>())
30-
return Queue.ext_oneapi_submit_barrier();
31-
32-
// Otherwise, we use the internal implementation of the profiling tag.
3325
return Queue.submit(
3426
[=](handler &CGH) {
3527
sycl::detail::HandlerAccess::internalProfilingTagImpl(CGH);

sycl/source/detail/scheduler/commands.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3448,9 +3448,6 @@ ur_result_t ExecCGCommand::enqueueImpQueue() {
34483448

34493449
// If the queue is not in-order, the implementation will need to first
34503450
// insert a marker event that the timestamp waits for.
3451-
// Note that with newer versions, MQueue should never have event profiling
3452-
// enabled here, as an optimization path in the headers will simply return
3453-
// the event from a barrier.
34543451
ur_event_handle_t PreTimestampMarkerEvent{};
34553452
if (!IsInOrderQueue) {
34563453
// FIXME: urEnqueueEventsWait on the L0 adapter requires a double-release.

0 commit comments

Comments
 (0)