deterministic order of erasing functions

wenju-he · wenju-he · commit db2ad4a2b6f5 · 2024-12-17T20:21:58.000-08:00
diff --git a/llvm/lib/SYCLLowerIR/LowerWGLocalMemory.cpp b/llvm/lib/SYCLLowerIR/LowerWGLocalMemory.cpp
@@ -116,9 +116,9 @@ static bool inlineGroupLocalMemoryFunc(Module &M) {
         assert(Result.isSuccess() && "inlining failed");
       }
     }
+    if (F != ALMFunc)
+      F->eraseFromParent();
   }
-  for (auto *F : Visited)
-    F->eraseFromParent();
 
   return !Visited.empty();
 }

Original file line number	Diff line number	Diff line change
`@@ -116,9 +116,9 @@ static bool inlineGroupLocalMemoryFunc(Module &M) {`
`116`	`116`	`assert(Result.isSuccess() && "inlining failed");`
`117`	`117`	`}`
`118`	`118`	`}`
	`119`	`+ if (F != ALMFunc)`
	`120`	`+ F->eraseFromParent();`
`119`	`121`	`}`
`120`		`- for (auto *F : Visited)`
`121`		`- F->eraseFromParent();`
`122`	`122`
`123`	`123`	`return !Visited.empty();`
`124`	`124`	`}`