[SYCL] Remove sycl::ext::oneapi::experimental::is_property_key (#16143)

This is an API-breaking change, but for an experimental feature and we
don't expect this particular interface was used by customers.

Author: aelovikov-intel

sycl/doc/extensions/experimental/sycl_ext_intel_cache_controls.asciidoc

@@ -196,8 +196,6 @@ inline constexpr read_hint_key::value_t<Cs...> read_hint;
 namespace oneapi {
 namespace experimental {
 
-template <>
-struct is_property_key<intel::experimental::read_hint_key> : std::true_type {};
 template <typename T, typename PropertyListT>
 struct is_property_key_of<intel::experimental::read_hint_key,
                           annotated_ptr<T, PropertyListT>> : std::true_type {};
@@ -261,8 +259,6 @@ inline constexpr write_hint_key::value_t<Cs...> write_hint;
 namespace oneapi {
 namespace experimental {
 
-template <>
-struct is_property_key<intel::experimental::write_hint_key> : std::true_type {};
 template <typename T, typename PropertyListT>
 struct is_property_key_of<intel::experimental::write_hint_key,
                           annotated_ptr<T, PropertyListT>> : std::true_type {};
@@ -336,9 +332,6 @@ inline constexpr read_assertion_key::value_t<Cs...> read_assertion;
 namespace oneapi {
 namespace experimental {
 
-template <>
-struct is_property_key<intel::experimental::read_assertion_key>
-    : std::true_type {};
 template <typename T, typename PropertyListT>
 struct is_property_key_of<intel::experimental::read_assertion_key,
                           annotated_ptr<T, PropertyListT>> : std::true_type {};

sycl/doc/extensions/experimental/sycl_ext_intel_fpga_task_sequence.asciidoc

@@ -299,10 +299,6 @@ inline constexpr invocation_capacity_key::value_t<Size> invocation_capacity;
 template <uint32_t Size>
 inline constexpr response_capacity_key::value_t<Size> response_capacity;
 
-template <> struct is_property_key<balanced_key> : std::true_type {};
-template <> struct is_property_key<invocation_capacity_key> : std::true_type {};
-template <> struct is_property_key<response_capacity_key> : std::true_type {};
-
 template <auto &f, typename PropertyListT>
 struct is_property_key_of<balanced_key, task_sequence<f, PropertyListT>>
   : std::true_type {};

sycl/doc/extensions/experimental/sycl_ext_oneapi_device_global.asciidoc

@@ -688,11 +688,6 @@ inline constexpr implement_in_csr_key::value_t<Enable> implement_in_csr;
 inline constexpr implement_in_csr_key::value_t<true> implement_in_csr_on;
 inline constexpr implement_in_csr_key::value_t<false> implement_in_csr_off;
 
-template <> struct is_property_key<device_image_scope_key> : std::true_type {};
-template <> struct is_property_key<host_access_key> : std::true_type {};
-template <> struct is_property_key<init_mode_key> : std::true_type {};
-template <> struct is_property_key<implement_in_csr_key> : std::true_type {};
-
 template <typename T, typename PropertyListT>
 struct is_property_key_of<device_image_scope_key, device_global<T, PropertyListT>>
   : std::true_type {};

sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_arg_properties.asciidoc

@@ -104,9 +104,6 @@ struct restrict_key {
 
 inline constexpr restrict_key::value_t restrict;
 
-template<>
-struct is_property_key<restrict_key> : std::true_type {};
-
 template<typename T, typename PropertyListT>
 struct is_property_key_of<
   restrict_key, annotated_ptr<T, PropertyListT>> : std::true_type {};
@@ -132,9 +129,6 @@ struct alignment_key {
 template<int K>
 inline constexpr alignment_key::value_t<K> alignment;
 
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::alignment_key> : std::true_type {};
-
 template<typename T, typename PropertyListT>
 struct is_property_key_of<
   alignment_key, annotated_ptr<T, PropertyListT>> : std::true_type {};

sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_compiler.asciidoc

@@ -311,9 +311,6 @@ struct build_options {
 };
 using build_options_key = build_options;
 
-template<>
-struct is_property_key<build_options_key> : std::true_type {};
-
 } // namespace sycl::ext::oneapi::experimental
 ----
 !====
@@ -345,9 +342,6 @@ struct save_log {
 };
 using save_log_key = save_log;
 
-template<>
-struct is_property_key<save_log_key> : std::true_type {};
-
 } // namespace sycl::ext::oneapi::experimental
 ----
 !====

sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_properties.asciidoc

@@ -181,11 +181,6 @@ inline constexpr sub_group_size_key::value_t<Size> sub_group_size;
 template <sycl::aspect... Aspects>
 inline constexpr device_has_key::value_t<Aspects...> device_has;
 
-template <> struct is_property_key<work_group_size_key> : std::true_type {};
-template <> struct is_property_key<work_group_size_hint_key> : std::true_type {};
-template <> struct is_property_key<sub_group_size_key> : std::true_type {};
-template <> struct is_property_key<device_has_key> : std::true_type {};
-
 } // namespace experimental
 } // namespace oneapi
 } // namespace ext
@@ -261,9 +256,6 @@ inline constexpr max_work_group_size_key::value_t<Dims...> max_work_group_size;
 template <size_t Size>
 inline constexpr max_linear_work_group_size_key::value_t<Size> max_linear_work_group_size;
 
-template <> struct is_property_key<max_work_group_size_key> : std::true_type {};
-template <> struct is_property_key<max_linear_work_group_size_key> : std::true_type {};
-
 } // namespace experimental
 } // namespace oneapi
 } // namespace ext

sycl/doc/extensions/experimental/sycl_ext_oneapi_properties.asciidoc

@@ -199,39 +199,26 @@ inline constexpr boo_key::value_t<Ts...> boo;
 
 === Property traits
 
-All runtime and compile-time-constant properties must have a specialization of 
-`is_property_key` and `is_property_value` that inherits from
-`std::true_type`, and they must have a specialization of `is_property_key_of`
-and `is_property_value_of`
-that inherits from `std::true_type` for each SYCL runtime class that the
-property can be applied to. All have a base case which inherits from `std::false_type`.
+Properties may add a specialization of `is_property_key_of` that inherits from
+`std::true_type` for each SYCL runtime class that the property can be applied
+to. All have a base case which inherits from `std::false_type`.
 
 ```c++
 namespace sycl::ext::oneapi::experimental {
 //Base case
-template<typename> struct is_property_key : std::false_type {};
 template<typename, typename> struct is_property_key_of : std::false_type {};
 
-template<> struct is_property_key<foo_key> : std::true_type {};
-template<> struct is_property_key<bar_key> : std::true_type {};
-
 // These properties can be applied to any SYCL object.
 template<typename SyclObjectT>
 struct is_property_key_of<foo_key, SyclObjectT> : std::true_type {};
 template<typename SyclObjectT>
 struct is_property_key_of<bar_key, SyclObjectT> : std::true_type {};
 
-// is_property_value and is_property_value_of based on is_property_key(_of)
-template<typename V, typename=void> struct is_property_value;
-template<typename V, typename O, typename=void> struct is_property_value_of;
-// Specialization for runtime properties
-template<typename V> struct is_property_value<V, std::enable_if_t<(sizeof(V)>0)>> : is_property_key<V> {};
-template<typename V, typename O> struct is_property_value_of<V, O, std::enable_if_t<(sizeof(V)>0)>> : is_property_key_of<V,O> {};
-// Specialization for compile-time-constant properties
-template<typename V> struct is_property_value<V, std::void_t<typename V::key_t>> :
-  is_property_key<typename V::key_t> {};
-template<typename V, typename O> struct is_property_value_of<V, O, std::void_t<typename V::key_t>> :
-  is_property_key_of<typename V::key_t, O> {};
+
+// is_property_value is provided by the properties infrastructure in implementation-defined way
+template<typename V> struct is_property_value;
+// is_property_value_of is based on is_property_key_of, implementation is provided by the properties infrastructure
+template<typename V, typename O> struct is_property_value_of;
 
 } // namespace experimental::oneapi::ext::sycl
 ```
@@ -636,7 +623,7 @@ This section provides more detailed information for implementers. It is non-norm
 Adding a new compile-time constant property requires implementers to introduce the following:
 
 * A new class representing the property key
-* Specializations of `sycl::is_property_key` and `sycl::is_property_key_of` for the new property class
+* Specialization of `sycl::is_property_key_of` for the new property class
 * A global variable that represents an object of the property value
 
 === Example of a Compile-time Constant Property
@@ -657,10 +644,6 @@ struct foo_key {
 template<int K>
 inline constexpr foo::value_t<K> foo;
 
-// foo is a property
-template<>
-struct is_property_key<foo_key> : std::true_type {};
-
 // foo can be applied to any object
 template<typename SyclObjectT>
 struct is_property_key_of<foo_key, SyclObjectT> : std::true_type {};

sycl/doc/extensions/proposed/sycl_ext_intel_fpga_kernel_arg_properties.asciidoc

@@ -236,27 +236,6 @@ inline constexpr wait_request_key::value_t<false>
 
 // Type trait specializations
 namespace sycl::ext::oneapi::experimental {
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::conduit_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::register_map_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::stable_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::buffer_location_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::awidth_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::dwidth_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::read_write_mode_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::latency_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::maxburst_key> : std::true_type {};
-template<> struct is_property_key<
-  sycl::ext::intel::experimental::wait_request_key> : std::true_type {};
-
 template <typename T, typename PropertyListT>
 struct is_property_key_of<
   sycl::ext::intel::experimental::conduit_key,

sycl/doc/extensions/proposed/sycl_ext_intel_fpga_kernel_interface_properties.asciidoc

@@ -167,10 +167,6 @@ inline constexpr fpga_cluster_key::value_t<
 inline constexpr fpga_cluster_key::value_t<
   fpga_cluster_options_enum::stall_free_clusters> stall_free_clusters;
 
-template <> struct is_property_key<streaming_interface_key> : std::true_type {};
-template <> struct is_property_key<register_map_interface_key> : std::true_type {};
-template <> struct is_property_key<fpga_cluster_key> : std::true_type {};
-
 } // namespace sycl::ext::intel::experimental
 ```
 
@@ -347,4 +343,4 @@ q.single_task(KernelFunctor{a, b, c}).wait();
 |1|2022-03-01|Abhishek Tiwari|*Initial public working draft*
 |2|2022-12-05|Abhishek Tiwari|*Make pipelined property parameter a signed int*
 |3|2024-01-05|Bowen Xue|*Add fpga_cluster property*
-|========================================
+|========================================

sycl/doc/extensions/proposed/sycl_ext_oneapi_forward_progress.asciidoc

@@ -423,10 +423,6 @@ inline constexpr sub_group_progress_key::value_t<Guarantee, CoordinationScope> s
 template <forward_progress_guarantee Guarantee, execution_scope CoordinationScope>
 inline constexpr work_item_progress_key::value_t<Guarantee, CoordinationScope> work_item_progress;
 
-template <> struct is_property_key<work_group_progress_key> : std::true_type {};
-template <> struct is_property_key<sub_group_progress_key> : std::true_type {};
-template <> struct is_property_key<work_item_progress_key> : std::true_type {};
-
 }
 ----