Skip to content

Commit e423dbb

Browse files
[Bench] Clean up regression printing info in compare.py
1 parent ed3809b commit e423dbb

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

devops/scripts/benchmarks/compare.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ def print_regression(entry: dict, is_warning: bool = False):
411411
log_func(f"-- Delta: {entry['delta']}")
412412
log_func("")
413413
if args.produce_github_summary:
414-
gh_summary.append(f"#### {entry['name']}:")
414+
gh_summary.append(f"##### {entry['name']}:")
415415
gh_summary.append(
416416
f"- Historic {entry['avg_type']}: {entry['hist_avg']}"
417417
)
@@ -427,12 +427,16 @@ def print_regression(entry: dict, is_warning: bool = False):
427427
)
428428
gh_summary.append("")
429429

430+
if args.produce_github_summary:
431+
gh_summary.append("")
432+
gh_summary.append("### Regressions and Improvements")
433+
430434
if improvements:
431435
log.info("#")
432436
log.info("# Improvements:")
433437
log.info("#")
434438
if args.produce_github_summary:
435-
gh_summary.append(f"### Improvements")
439+
gh_summary.append(f"#### Improvements")
436440
gh_summary.append(
437441
f"<details><summary>{len(improvements)} improved tests:</summary>"
438442
)
@@ -444,12 +448,12 @@ def print_regression(entry: dict, is_warning: bool = False):
444448
gh_summary.append("")
445449
if regressions_ignored:
446450
log.info("#")
447-
log.info("# Regressions (filtered out by --regression-filter):")
451+
log.info(f"# Regressions Ignored (filtered out by --regression-filter: {filter_type_capitalized})")
448452
log.info("#")
449453
if args.produce_github_summary:
450-
gh_summary.append(f"### Non-{filter_type_capitalized} Regressions")
454+
gh_summary.append(f"#### Regressions Ignored (filtered out by --regression-filter: {filter_type_capitalized})")
451455
gh_summary.append(
452-
f"<details><summary>{len(regressions_ignored)} non-{args.regression_filter_type} regressions:</summary>"
456+
f"<details><summary>{len(regressions_ignored)} non-'{args.regression_filter_type}' regressions:</summary>"
453457
)
454458
gh_summary.append("")
455459
for test in regressions_ignored:
@@ -462,7 +466,7 @@ def print_regression(entry: dict, is_warning: bool = False):
462466
log.warning("# Regressions:")
463467
log.warning("#")
464468
if args.produce_github_summary:
465-
gh_summary.append(f"### {filter_type_capitalized} Regressions")
469+
gh_summary.append(f"#### {filter_type_capitalized} Regressions")
466470
gh_summary.append(
467471
f"{len(regressions_of_concern)} {args.regression_filter_type} regressions. These regressions warrant a CI failure:"
468472
)
@@ -480,8 +484,6 @@ def print_regression(entry: dict, is_warning: bool = False):
480484

481485
log.info("No unexpected regressions found!")
482486
if args.produce_github_summary:
483-
gh_summary.append("")
484-
gh_summary.append("### Regressions")
485487
gh_summary.append("No unexpected regressions found!")
486488
with open(options.github_summary_regression_filename, "w") as f:
487489
f.write("\n".join(gh_summary))

0 commit comments

Comments
 (0)