Apply comments

Author: AlexeySachkov

clang/lib/Sema/SemaSYCL.cpp

@@ -6834,15 +6834,16 @@ class FreeFunctionPrinter {
       auto TemplateArgPrinter = [&](const TemplateArgument &Arg) {
         if (Arg.getKind() != TemplateArgument::ArgKind::Expression ||
             Arg.isInstantiationDependent()) {
-          Arg.print(Policy, ParmListOstream, false /* IncludeType */);
+          Arg.print(Policy, ParmListOstream, /* IncludeType = */ false);
           return;
         }
 
         Expr *E = Arg.getAsExpr();
+        assert(E && "Failed to get an Expr for an Expression template arg?");
         if (E->getType().getTypePtr()->isScopedEnumeralType()) {
           // Scoped enumerations can't be implicitly cast from integers, so
-          // we don't need to evaluate them
-          Arg.print(Policy, ParmListOstream, false /* IncludeType */);
+          // we don't need to evaluate them.
+          Arg.print(Policy, ParmListOstream, /* IncludeType = */ false);
           return;
         }
 
@@ -6861,7 +6862,7 @@ class FreeFunctionPrinter {
         if (I != 0)
           ParmListOstream << ", ";
         // If we have a specialized argument, use it. Otherwise fallback to a
-        // default argument
+        // default argument.
         TemplateArgPrinter(I < SE ? SpecArgs[I] : DeclArgs[I]);
       }
 

clang/test/CodeGenSYCL/free-function-kernel-expr-as-template-arg.cpp

@@ -38,6 +38,10 @@ enum class class_enum_typed : int {
   VAL_D
 };
 
+constexpr int bar(int arg) {
+  return arg + 42;
+}
+
 } // namespace ns
 
 template<int V>
@@ -99,3 +103,8 @@ void constexpr_ns2(Arg4<ns::class_enum::VAL_A>) {}
 void constexpr_ns2(Arg5<ns::class_enum_typed::VAL_C>) {}
 
 // CHECK: void constexpr_ns2(Arg5<ns::class_enum_typed::VAL_C> );
+
+[[__sycl_detail__::add_ir_attributes_function("sycl-nd-range-kernel", 2)]]
+void constexpr_call(Arg<ns::bar(B)>) {}
+
+// CHECK: void constexpr_call(Arg<45> );