Skip to content

Commit e5436bf

Browse files
committed
[SYCL][E2E] Add test to track RUNx tests
The same idea as for XFAIL and UNSUPPORTED. The test checks if there is a RUNx without tracker. Also: - this PR also updates some RUNx tests as they are likely fixed. - marks some as UNSUPPORTED as there is only one RUNx line. - adds tracker for the rest. After that there shouldn't be any untracked RUNx tests in sycl/test-e2e.
1 parent 21018ab commit e5436bf

File tree

10 files changed

+43
-11
lines changed

10 files changed

+43
-11
lines changed

sycl/test-e2e/Basic/fpga_tests/fpga_io_pipes.cpp

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
1+
// The test is disabled, since no support added in FPGA backend yet. Check
2+
// implementation correctness from CXX and SYCL languages perspective.
3+
// UNSUPPORTED: true
4+
15
// REQUIRES: accelerator
26
// RUN: %{build} -o %t.out
3-
// RUNx: %{run} %t.out
7+
// RUN: %{run} %t.out
48
//==------------ fpga_io_pipes.cpp - SYCL FPGA pipes test ------------------==//
59
//
610
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
@@ -15,9 +19,6 @@
1519

1620
#include "io_pipe_def.h"
1721

18-
// TODO: run is disabled, since no support added in FPGA backend yet. Check
19-
// implementation correctness from CXX and SYCL languages perspective.
20-
2122
// This test is supposed to be run only on Intel FPGA emulator. Change it when
2223
// we have more experience with IO pipe feature in SYCL.
2324
// The emulator creates files (one for I pipe, another for O pipe) with the

sycl/test-e2e/Graph/Explicit/host_task_last.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
// Extra run to check for leaks in Level Zero using UR_L0_LEAKS_DEBUG
44
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
55

6-
// Disabled due to https://github.com/intel/llvm/issues/14473
76
// Extra run to check for immediate-command-list in Level Zero
87
// RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
8+
// RUNx-TRACKER: https://github.com/intel/llvm/issues/14473
99

1010
// REQUIRES: aspect-usm_shared_allocations
1111

sycl/test-e2e/Graph/RecordReplay/host_task_last.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
// Extra run to check for leaks in Level Zero using UR_L0_LEAKS_DEBUG
44
// RUN: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=0 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
55

6-
// Disabled due to https://github.com/intel/llvm/issues/14473
76
// Extra run to check for immediate-command-list in Level Zero
87
// RUNx: %if level_zero %{env SYCL_PI_LEVEL_ZERO_USE_IMMEDIATE_COMMANDLISTS=1 %{l0_leak_check} %{run} %t.out 2>&1 | FileCheck %s --implicit-check-not=LEAK %}
8+
// RUNx-TRACKER: https://github.com/intel/llvm/issues/14473
99

1010
// REQUIRES: aspect-usm_shared_allocations
1111

sycl/test-e2e/OptionalKernelFeatures/fp64-conv-emu.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22
// UNSUPPORTED: cuda, hip
33

44
// RUN: %clangxx -fsycl -fsycl-targets=spir64_gen -Xsycl-target-backend "-device pvc" -fsycl-fp64-conv-emu -O0 %s -o %t_opt.out
5-
// TODO: Enable when GPU driver is updated.
6-
// RUNx: %{run} %t_opt.out
5+
// RUN: %{run} %t_opt.out
76

87
// Tests that aspect::fp64 is not emitted correctly when -fsycl-fp64-conv-emu
98
// flag is used.

sycl/test-e2e/Regression/isordered.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %{build} -o %t.out
2-
// RUNx: %{run} %t.out
2+
// RUN: %{run} %t.out
33

44
#include <sycl/detail/core.hpp>
55

sycl/test-e2e/Regression/mad_sat.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// RUN: %{build} -Wno-error=integer-overflow -Wno-error=implicitly-unsigned-literal -o %t.out
2-
// RUNx: %{run} %t.out
2+
// RUN: %{run} %t.out
33

44
#include <sycl/detail/core.hpp>
55

sycl/test-e2e/SharedLib/use_with_dlopen.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
// This causes SEG. FAULT.
1717
// RUNx: %{compile} -o %t4.out -DRUN_LAST
1818
// RUNx: %{run} %t4.out
19+
// RUNx-TRACKER: https://github.com/intel/llvm/issues/16031
1920

2021
#include <sycl/detail/core.hpp>
2122

sycl/test-e2e/SharedLib/use_with_dlopen_verify_cache.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
// This causes SEG. FAULT.
1818
// RUNx: %{compile} -DRUN_LAST
1919
// RUNx: env SYCL_UR_TRACE=2 %{run} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-LAST,CHECK --implicit-check-not=piProgramBuild
20+
// RUNx-TRACKER: https://github.com/intel/llvm/issues/16031
2021
// clang-format on
2122

2223
#include <sycl/detail/core.hpp>
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
// This test is intended to ensure that we have no tests marked as RUNx
2+
// without a tracker information added to a test. If it fails - please create
3+
// a tracker for RUNx-marked test.
4+
//
5+
// The format we check is:
6+
// RUNx: command
7+
// RUNx-TRACKER: [GitHub issue URL|Internal tracker ID]
8+
//
9+
// GitHub issue URL format:
10+
// https://github.com/owner/repo/issues/12345
11+
//
12+
// Internal tracker ID format:
13+
// PROJECT-123456
14+
//
15+
// REQUIRES: linux
16+
//
17+
// Explanation of the command:
18+
// - search for all "RUNx" occurrences, display line with match and the next one
19+
// -I, --include to drop binary files and other unrelated files
20+
// - in the result, search for "RUNx" again, but invert the result - this
21+
// allows us to get the line *after* RUNx
22+
// - in those lines, check that RUNx-TRACKER is present and correct. Once
23+
// again, invert the search to get all "bad" lines; running it with "not" as
24+
// grep exits with 1 if it finds nothing
25+
//
26+
// RUN: grep -rI "RUNx:" %S/../../test-e2e \
27+
// RUN: -A 1 --include=*.cpp --no-group-separator | \
28+
// RUN: grep -v "RUNx:" | \
29+
// RUN: not grep -Pv "RUNx-TRACKER:\s+(?:https://github.com/[\w\d-]+/[\w\d-]+/issues/[\d]+)|(?:[\w]+-[\d]+)"

sycl/test/e2e_test_requirements/no-unsupported-without-info.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
// tests to match the required format and in that case you should just update
5555
// (i.e. reduce) the number and the list below.
5656
//
57-
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 477
57+
// NUMBER-OF-UNSUPPORTED-WITHOUT-INFO: 478
5858
//
5959
// List of improperly UNSUPPORTED tests.
6060
// Remove the CHECK once the test has been properly UNSUPPORTED.
@@ -77,6 +77,7 @@
7777
// CHECK-NEXT: Basic/buffer/subbuffer.cpp
7878
// CHECK-NEXT: Basic/build_log.cpp
7979
// CHECK-NEXT: Basic/code_location_e2e.cpp
80+
// CHECK-NEXT: Basic/fpga_tests/fpga_io_pipes.cpp
8081
// CHECK-NEXT: Basic/free_function_queries/free_function_queries.cpp
8182
// CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp
8283
// CHECK-NEXT: Basic/free_function_queries/free_function_queries_sub_group.cpp

0 commit comments

Comments
 (0)