Skip to content

Commit e690e43

Browse files
committed
Fix unittest cmake
Signed-off-by: Larsen, Steffen <[email protected]>
1 parent e1eec5f commit e690e43

File tree

3 files changed

+19
-10
lines changed

3 files changed

+19
-10
lines changed

sycl/unittests/assert/CMakeLists.txt

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,8 @@ add_sycl_unittest(AssertTests OBJECT
99
check_cxx_compiler_flag(-Wno-error=\#warnings HAS_NO_HASH_WARNINGS_OPT)
1010
check_cxx_compiler_flag(-Wno-error=pedantic HAS_NO_PEDANTIC_WARNINGS_OPT)
1111
check_cxx_compiler_flag(-Wno-error=cpp HAS_NO_CPP_WARNINGS_OPT)
12-
target_compile_options(
13-
AssertTests
14-
PRIVATE
15-
$<$<BOOL:${HAS_NO_HASH_WARNINGS_OPT}>:-Wno-error=\#warnings>
16-
$<$<BOOL:${HAS_NO_PEDANTIC_WARNINGS_OPT}>:-Wno-error=pedantic>
17-
$<$<BOOL:${HAS_NO_CPP_WARNINGS_OPT}>:-Wno-error=cpp>
12+
add_compile_options(
13+
$<$<BOOL:${HAS_NO_HASH_WARNINGS_OPT}>:-Wno-error=\#warnings>
14+
$<$<BOOL:${HAS_NO_PEDANTIC_WARNINGS_OPT}>:-Wno-error=pedantic>
15+
$<$<BOOL:${HAS_NO_CPP_WARNINGS_OPT}>:-Wno-error=cpp>
1816
)

sycl/unittests/assert/assert.cpp

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ struct KernelInfo<TestKernel> : public unittest::MockKernelInfoBase {
5252
static constexpr const kernel_param_desc_t Signatures[] = {
5353
{kernel_param_kind_t::kind_accessor, 4062, 0}};
5454

55+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
5556
template <>
5657
struct KernelInfo<::sycl::detail::__sycl_service_kernel__::AssertInfoCopier>
5758
: public unittest::MockKernelInfoBase {
@@ -69,6 +70,7 @@ struct KernelInfo<::sycl::detail::__sycl_service_kernel__::AssertInfoCopier>
6970
sycl::access::mode::write>);
7071
}
7172
};
73+
#endif
7274
} // namespace detail
7375
} // namespace _V1
7476
} // namespace sycl
@@ -77,8 +79,6 @@ static sycl::unittest::MockDeviceImage generateDefaultImage() {
7779
using namespace sycl::unittest;
7880

7981
static const std::string KernelName = "TestKernel";
80-
static const std::string CopierKernelName =
81-
"_ZTSN2cl4sycl6detail23__sycl_service_kernel__16AssertInfoCopierE";
8282

8383
MockPropertySet PropSet;
8484

@@ -91,6 +91,7 @@ static sycl::unittest::MockDeviceImage generateDefaultImage() {
9191
return Img;
9292
}
9393

94+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
9495
static sycl::unittest::MockDeviceImage generateCopierKernelImage() {
9596
using namespace sycl::unittest;
9697

@@ -105,9 +106,13 @@ static sycl::unittest::MockDeviceImage generateCopierKernelImage() {
105106

106107
return Img;
107108
}
109+
#endif
108110

109-
sycl::unittest::MockDeviceImage Imgs[] = {generateDefaultImage(),
110-
generateCopierKernelImage()};
111+
sycl::unittest::MockDeviceImage Imgs[] = {
112+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
113+
generateCopierKernelImage(),
114+
#endif
115+
generateDefaultImage()};
111116
sycl::unittest::MockDeviceImageArray<2> ImgArray{Imgs};
112117

113118
struct AssertHappened {
@@ -501,6 +506,7 @@ TEST(Assert, TestPositive) {
501506
#endif // _WIN32
502507
}
503508

509+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
504510
TEST(Assert, TestAssertServiceKernelHidden) {
505511
const char *AssertServiceKernelName = sycl::detail::KernelInfo<
506512
sycl::detail::__sycl_service_kernel__::AssertInfoCopier>::getName();
@@ -514,6 +520,7 @@ TEST(Assert, TestAssertServiceKernelHidden) {
514520

515521
EXPECT_TRUE(NoFoundServiceKernelID);
516522
}
523+
#endif
517524

518525
TEST(Assert, TestInteropKernelNegative) {
519526
sycl::unittest::UrMock<> Mock;

sycl/unittests/program_manager/Cleanup.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,11 +29,13 @@ class ProgramManagerExposed : public sycl::detail::ProgramManager {
2929
return m_BinImg2KernelIDs;
3030
}
3131

32+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
3233
std::unordered_multimap<sycl::detail::KernelNameStrT,
3334
const sycl::detail::RTDeviceBinaryImage *> &
3435
getServiceKernels() {
3536
return m_ServiceKernels;
3637
}
38+
#endif
3739

3840
std::unordered_multimap<std::string,
3941
const sycl::detail::RTDeviceBinaryImage *> &
@@ -264,6 +266,7 @@ void checkAllInvolvedContainers(ProgramManagerExposed &PM, size_t ExpectedCount,
264266
<< Comment;
265267
}
266268
EXPECT_EQ(PM.getBinImage2KernelId().size(), ExpectedCount) << Comment;
269+
#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
267270
{
268271
EXPECT_EQ(PM.getServiceKernels().size(), ExpectedCount) << Comment;
269272
EXPECT_TRUE(PM.getServiceKernels().count(
@@ -273,6 +276,7 @@ void checkAllInvolvedContainers(ProgramManagerExposed &PM, size_t ExpectedCount,
273276
generateRefName("B", "__sycl_service_kernel__")) > 0)
274277
<< Comment;
275278
}
279+
#endif
276280
{
277281
EXPECT_EQ(PM.getExportedSymbolImages().size(), ExpectedCount) << Comment;
278282
EXPECT_TRUE(PM.getExportedSymbolImages().count(

0 commit comments

Comments
 (0)