Skip to content

Commit e8a0a95

Browse files
FznamznonFznamznon
committed
Merge remote-tracking branch 'sycl-web' into llvmspirv_pulldown45
2 parents 5d0d4ef + e7aa612 commit e8a0a95

File tree

2,106 files changed

+78165
-28288
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,106 files changed

+78165
-28288
lines changed

‎bolt/lib/Rewrite/RewriteInstance.cpp

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -599,10 +599,19 @@ void RewriteInstance::parsePseudoProbe() {
599599
errs() << "BOLT-WARNING: fail in building GUID2FuncDescMap\n";
600600
return;
601601
}
602+
603+
MCPseudoProbeDecoder::Uint64Set GuidFilter;
604+
MCPseudoProbeDecoder::Uint64Map FuncStartAddrs;
605+
for (const BinaryFunction *F : BC->getAllBinaryFunctions()) {
606+
for (const MCSymbol *Sym : F->getSymbols()) {
607+
FuncStartAddrs[Function::getGUID(NameResolver::restore(Sym->getName()))] =
608+
F->getAddress();
609+
}
610+
}
602611
Contents = PseudoProbeSection->getContents();
603612
if (!BC->ProbeDecoder.buildAddress2ProbeMap(
604-
reinterpret_cast<const uint8_t *>(Contents.data()),
605-
Contents.size())) {
613+
reinterpret_cast<const uint8_t *>(Contents.data()), Contents.size(),
614+
GuidFilter, FuncStartAddrs)) {
606615
BC->ProbeDecoder.getAddress2ProbesMap().clear();
607616
errs() << "BOLT-WARNING: fail in building Address2ProbeMap\n";
608617
return;
@@ -3426,6 +3435,8 @@ void RewriteInstance::encodePseudoProbes() {
34263435
// Address of the first probe is absolute.
34273436
// Other probes' address are represented by delta
34283437
auto EmitDecodedPseudoProbe = [&](MCDecodedPseudoProbe *&CurProbe) {
3438+
assert(!isSentinelProbe(CurProbe->getAttributes()) &&
3439+
"Sentinel probes should not be emitted");
34293440
EmitULEB128IntValue(CurProbe->getIndex());
34303441
uint8_t PackedType = CurProbe->getType() | (CurProbe->getAttributes() << 4);
34313442
uint8_t Flag =
@@ -3530,9 +3541,17 @@ void RewriteInstance::encodePseudoProbes() {
35303541
reinterpret_cast<const uint8_t *>(DescContents.data()),
35313542
DescContents.size());
35323543
StringRef ProbeContents = PseudoProbeSection->getOutputContents();
3544+
MCPseudoProbeDecoder::Uint64Set GuidFilter;
3545+
MCPseudoProbeDecoder::Uint64Map FuncStartAddrs;
3546+
for (const BinaryFunction *F : BC->getAllBinaryFunctions()) {
3547+
const uint64_t Addr =
3548+
F->isEmitted() ? F->getOutputAddress() : F->getAddress();
3549+
FuncStartAddrs[Function::getGUID(
3550+
NameResolver::restore(F->getOneName()))] = Addr;
3551+
}
35333552
DummyDecoder.buildAddress2ProbeMap(
35343553
reinterpret_cast<const uint8_t *>(ProbeContents.data()),
3535-
ProbeContents.size());
3554+
ProbeContents.size(), GuidFilter, FuncStartAddrs);
35363555
DummyDecoder.printProbesForAllAddresses(outs());
35373556
}
35383557
}

‎bolt/test/AArch64/double_jump.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
// RUN: %clang %cflags -O0 %s -o %t.exe
44
// RUN: llvm-bolt %t.exe -o %t.bolt --peepholes=double-jumps | \
55
// RUN: FileCheck %s -check-prefix=CHECKBOLT
6-
// RUN: llvm-objdump -d %t.bolt | FileCheck %s
6+
// RUN: llvm-objdump --no-print-imm-hex -d %t.bolt | FileCheck %s
77

88
// CHECKBOLT: BOLT-INFO: Peephole: 1 double jumps patched.
99

‎bolt/test/pseudoprobe-decoding-inline.test

Lines changed: 117 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,117 @@
1+
# REQUIRES: system-linux
2+
# RUN: llvm-bolt %S/../../llvm/test/tools/llvm-profgen/Inputs/inline-cs-pseudoprobe.perfbin --print-pseudo-probes=all -o %t.bolt 2>&1 | FileCheck %s
3+
4+
CHECK: Report of decoding input pseudo probe binaries
5+
6+
CHECK-NEXT: Pseudo Probe Desc:
7+
CHECK-NEXT: GUID: 6699318081062747564 Name: foo
8+
CHECK-NEXT: Hash: 563088904013236
9+
CHECK-NEXT: GUID: 15822663052811949562 Name: main
10+
CHECK-NEXT: Hash: 281479271677951
11+
CHECK-NEXT: GUID: 16434608426314478903 Name: bar
12+
CHECK-NEXT: Hash: 72617220756
13+
14+
CHECK: [Probe]: FUNC: bar Index: 1 Type: Block
15+
CHECK: [Probe]: FUNC: bar Index: 4 Type: Block
16+
CHECK: [Probe]: FUNC: foo Index: 1 Type: Block
17+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block
18+
CHECK: [Probe]: FUNC: foo Index: 5 Type: Block
19+
CHECK: [Probe]: FUNC: foo Index: 6 Type: Block
20+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block
21+
CHECK: [Probe]: FUNC: foo Index: 3 Type: Block
22+
CHECK: [Probe]: FUNC: foo Index: 4 Type: Block
23+
CHECK: [Probe]: FUNC: bar Index: 1 Type: Block Inlined: @ foo:8
24+
CHECK: [Probe]: FUNC: bar Index: 4 Type: Block Inlined: @ foo:8
25+
CHECK: [Probe]: FUNC: foo Index: 6 Type: Block
26+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block
27+
CHECK: [Probe]: FUNC: foo Index: 7 Type: Block
28+
CHECK: [Probe]: FUNC: foo Index: 9 Type: DirectCall
29+
CHECK: [Probe]: FUNC: main Index: 1 Type: Block
30+
CHECK: [Probe]: FUNC: foo Index: 1 Type: Block Inlined: @ main:2
31+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block Inlined: @ main:2
32+
CHECK: [Probe]: FUNC: foo Index: 5 Type: Block Inlined: @ main:2
33+
CHECK: [Probe]: FUNC: foo Index: 6 Type: Block Inlined: @ main:2
34+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block Inlined: @ main:2
35+
CHECK: [Probe]: FUNC: foo Index: 3 Type: Block Inlined: @ main:2
36+
CHECK: [Probe]: FUNC: foo Index: 4 Type: Block Inlined: @ main:2
37+
CHECK: [Probe]: FUNC: bar Index: 1 Type: Block Inlined: @ main:2 @ foo:8
38+
CHECK: [Probe]: FUNC: bar Index: 4 Type: Block Inlined: @ main:2 @ foo:8
39+
CHECK: [Probe]: FUNC: foo Index: 6 Type: Block Inlined: @ main:2
40+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block Inlined: @ main:2
41+
CHECK: [Probe]: FUNC: foo Index: 7 Type: Block Inlined: @ main:2
42+
CHECK: [Probe]: FUNC: foo Index: 9 Type: DirectCall Inlined: @ main:2
43+
44+
CHECK: Pseudo Probe Address Conversion results:
45+
46+
CHECK: Address: 0x201750 FUNC: bar Index: 1 Type: Block
47+
CHECK: Address: 0x201750 FUNC: bar Index: 4 Type: Block
48+
CHECK: Address: 0x201770 FUNC: foo Index: 1 Type: Block
49+
CHECK: Address: 0x201770 FUNC: foo Index: 2 Type: Block
50+
CHECK: Address: 0x20177d FUNC: foo Index: 5 Type: Block
51+
CHECK: Address: 0x20177d FUNC: foo Index: 6 Type: Block
52+
CHECK: Address: 0x20177d FUNC: foo Index: 2 Type: Block
53+
CHECK: Address: 0x20178b FUNC: foo Index: 3 Type: Block
54+
CHECK: Address: 0x2017aa FUNC: foo Index: 4 Type: Block
55+
CHECK: Address: 0x2017aa FUNC: bar Index: 1 Type: Block Inlined: @ foo:8
56+
CHECK: Address: 0x2017aa FUNC: bar Index: 4 Type: Block Inlined: @ foo:8
57+
CHECK: Address: 0x2017aa FUNC: foo Index: 6 Type: Block
58+
CHECK: Address: 0x2017aa FUNC: foo Index: 2 Type: Block
59+
CHECK: Address: 0x2017d7 FUNC: foo Index: 7 Type: Block
60+
CHECK: Address: 0x2017e2 FUNC: foo Index: 9 Type: DirectCall
61+
CHECK: Address: 0x2017f0 FUNC: main Index: 1 Type: Block
62+
CHECK: Address: 0x2017f0 FUNC: foo Index: 1 Type: Block Inlined: @ main:2
63+
CHECK: Address: 0x2017f0 FUNC: foo Index: 2 Type: Block Inlined: @ main:2
64+
CHECK: Address: 0x2017fd FUNC: foo Index: 5 Type: Block Inlined: @ main:2
65+
CHECK: Address: 0x2017fd FUNC: foo Index: 6 Type: Block Inlined: @ main:2
66+
CHECK: Address: 0x2017fd FUNC: foo Index: 2 Type: Block Inlined: @ main:2
67+
CHECK: Address: 0x20180b FUNC: foo Index: 3 Type: Block Inlined: @ main:2
68+
CHECK: Address: 0x20182a FUNC: foo Index: 4 Type: Block Inlined: @ main:2
69+
CHECK: Address: 0x20182a FUNC: bar Index: 1 Type: Block Inlined: @ main:2 @ foo:8
70+
CHECK: Address: 0x20182a FUNC: bar Index: 4 Type: Block Inlined: @ main:2 @ foo:8
71+
CHECK: Address: 0x20182a FUNC: foo Index: 6 Type: Block Inlined: @ main:2
72+
CHECK: Address: 0x20182a FUNC: foo Index: 2 Type: Block Inlined: @ main:2
73+
CHECK: Address: 0x201857 FUNC: foo Index: 7 Type: Block Inlined: @ main:2
74+
CHECK: Address: 0x201862 FUNC: foo Index: 9 Type: DirectCall Inlined: @ main:2
75+
76+
CHECK: Address: 2103120
77+
CHECK-NEXT: [Probe]: FUNC: bar Index: 1 Type: Block
78+
CHECK-NEXT: [Probe]: FUNC: bar Index: 4 Type: Block
79+
CHECK-NEXT: Address: 2103152
80+
CHECK-NEXT: [Probe]: FUNC: foo Index: 1 Type: Block
81+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block
82+
CHECK-NEXT: Address: 2103165
83+
CHECK-NEXT: [Probe]: FUNC: foo Index: 5 Type: Block
84+
CHECK-NEXT: [Probe]: FUNC: foo Index: 6 Type: Block
85+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block
86+
CHECK-NEXT: Address: 2103179
87+
CHECK-NEXT: [Probe]: FUNC: foo Index: 3 Type: Block
88+
CHECK-NEXT: Address: 2103210
89+
CHECK-NEXT: [Probe]: FUNC: foo Index: 4 Type: Block
90+
CHECK-NEXT: [Probe]: FUNC: foo Index: 6 Type: Block
91+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block
92+
CHECK-NEXT: [Probe]: FUNC: bar Index: 1 Type: Block Inlined: @ foo:8
93+
CHECK-NEXT: [Probe]: FUNC: bar Index: 4 Type: Block Inlined: @ foo:8
94+
CHECK-NEXT: Address: 2103255
95+
CHECK-NEXT: [Probe]: FUNC: foo Index: 7 Type: Block
96+
CHECK-NEXT: Address: 2103266
97+
CHECK-NEXT: [Probe]: FUNC: foo Index: 9 Type: DirectCall
98+
CHECK-NEXT: Address: 2103280
99+
CHECK-NEXT: [Probe]: FUNC: main Index: 1 Type: Block
100+
CHECK-NEXT: [Probe]: FUNC: foo Index: 1 Type: Block Inlined: @ main:2
101+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block Inlined: @ main:2
102+
CHECK-NEXT: Address: 2103293
103+
CHECK-NEXT: [Probe]: FUNC: foo Index: 5 Type: Block Inlined: @ main:2
104+
CHECK-NEXT: [Probe]: FUNC: foo Index: 6 Type: Block Inlined: @ main:2
105+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block Inlined: @ main:2
106+
CHECK-NEXT: Address: 2103307
107+
CHECK-NEXT: [Probe]: FUNC: foo Index: 3 Type: Block Inlined: @ main:2
108+
CHECK-NEXT: Address: 2103338
109+
CHECK-NEXT: [Probe]: FUNC: foo Index: 4 Type: Block Inlined: @ main:2
110+
CHECK-NEXT: [Probe]: FUNC: foo Index: 6 Type: Block Inlined: @ main:2
111+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block Inlined: @ main:2
112+
CHECK-NEXT: [Probe]: FUNC: bar Index: 1 Type: Block Inlined: @ main:2 @ foo:8
113+
CHECK-NEXT: [Probe]: FUNC: bar Index: 4 Type: Block Inlined: @ main:2 @ foo:8
114+
CHECK-NEXT: Address: 2103383
115+
CHECK-NEXT: [Probe]: FUNC: foo Index: 7 Type: Block Inlined: @ main:2
116+
CHECK-NEXT: Address: 2103394
117+
CHECK-NEXT: [Probe]: FUNC: foo Index: 9 Type: DirectCall Inlined: @ main:2

‎bolt/test/pseudoprobe-decoding-noinline.test

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,74 @@
1+
# REQUIRES: system-linux
2+
# RUN: llvm-bolt %S/../../llvm/test/tools/llvm-profgen/Inputs/noinline-cs-pseudoprobe.perfbin --print-pseudo-probes=all -o %t.bolt 2>&1 | FileCheck %s
3+
4+
;; Report of decoding input pseudo probe binaries
5+
6+
; CHECK: GUID: 6699318081062747564 Name: foo
7+
; CHECK: Hash: 563088904013236
8+
; CHECK: GUID: 15822663052811949562 Name: main
9+
; CHECK: Hash: 281479271677951
10+
; CHECK: GUID: 16434608426314478903 Name: bar
11+
; CHECK: Hash: 72617220756
12+
13+
CHECK: [Probe]: FUNC: bar Index: 1 Type: Block
14+
CHECK: [Probe]: FUNC: bar Index: 4 Type: Block
15+
CHECK: [Probe]: FUNC: foo Index: 1 Type: Block
16+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block
17+
CHECK: [Probe]: FUNC: foo Index: 5 Type: Block
18+
CHECK: [Probe]: FUNC: foo Index: 6 Type: Block
19+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block
20+
CHECK: [Probe]: FUNC: foo Index: 3 Type: Block
21+
CHECK: [Probe]: FUNC: foo Index: 4 Type: Block
22+
CHECK: [Probe]: FUNC: foo Index: 8 Type: DirectCall
23+
CHECK: [Probe]: FUNC: foo Index: 6 Type: Block
24+
CHECK: [Probe]: FUNC: foo Index: 2 Type: Block
25+
CHECK: [Probe]: FUNC: foo Index: 7 Type: Block
26+
CHECK: [Probe]: FUNC: foo Index: 9 Type: DirectCall
27+
CHECK: [Probe]: FUNC: main Index: 1 Type: Block
28+
CHECK: [Probe]: FUNC: main Index: 2 Type: DirectCall
29+
30+
CHECK: Pseudo Probe Address Conversion results:
31+
32+
CHECK: Address: 0x201760 FUNC: bar Index: 1 Type: Block
33+
CHECK: Address: 0x201760 FUNC: bar Index: 4 Type: Block
34+
CHECK: Address: 0x201780 FUNC: foo Index: 1 Type: Block
35+
CHECK: Address: 0x201780 FUNC: foo Index: 2 Type: Block
36+
CHECK: Address: 0x20178d FUNC: foo Index: 5 Type: Block
37+
CHECK: Address: 0x20178d FUNC: foo Index: 6 Type: Block
38+
CHECK: Address: 0x20178d FUNC: foo Index: 2 Type: Block
39+
CHECK: Address: 0x20179b FUNC: foo Index: 3 Type: Block
40+
CHECK: Address: 0x2017ba FUNC: foo Index: 4 Type: Block
41+
CHECK: Address: 0x2017bc FUNC: foo Index: 8 Type: DirectCall
42+
CHECK: Address: 0x2017ba FUNC: foo Index: 6 Type: Block
43+
CHECK: Address: 0x2017ba FUNC: foo Index: 2 Type: Block
44+
CHECK: Address: 0x2017ce FUNC: foo Index: 7 Type: Block
45+
CHECK: Address: 0x2017d5 FUNC: foo Index: 9 Type: DirectCall
46+
CHECK: Address: 0x2017f0 FUNC: main Index: 1 Type: Block
47+
CHECK: Address: 0x2017f4 FUNC: main Index: 2 Type: DirectCall
48+
49+
CHECK: Address: 2103136
50+
CHECK-NEXT: [Probe]: FUNC: bar Index: 1 Type: Block
51+
CHECK-NEXT: [Probe]: FUNC: bar Index: 4 Type: Block
52+
CHECK-NEXT: Address: 2103168
53+
CHECK-NEXT: [Probe]: FUNC: foo Index: 1 Type: Block
54+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block
55+
CHECK-NEXT: Address: 2103181
56+
CHECK-NEXT: [Probe]: FUNC: foo Index: 5 Type: Block
57+
CHECK-NEXT: [Probe]: FUNC: foo Index: 6 Type: Block
58+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block
59+
CHECK-NEXT: Address: 2103195
60+
CHECK-NEXT: [Probe]: FUNC: foo Index: 3 Type: Block
61+
CHECK-NEXT: Address: 2103226
62+
CHECK-NEXT: [Probe]: FUNC: foo Index: 4 Type: Block
63+
CHECK-NEXT: [Probe]: FUNC: foo Index: 6 Type: Block
64+
CHECK-NEXT: [Probe]: FUNC: foo Index: 2 Type: Block
65+
CHECK-NEXT: Address: 2103228
66+
CHECK-NEXT: [Probe]: FUNC: foo Index: 8 Type: DirectCall
67+
CHECK-NEXT: Address: 2103246
68+
CHECK-NEXT: [Probe]: FUNC: foo Index: 7 Type: Block
69+
CHECK-NEXT: Address: 2103253
70+
CHECK-NEXT: [Probe]: FUNC: foo Index: 9 Type: DirectCall
71+
CHECK-NEXT: Address: 2103280
72+
CHECK-NEXT: [Probe]: FUNC: main Index: 1 Type: Block
73+
CHECK-NEXT: Address: 2103284
74+
CHECK-NEXT: [Probe]: FUNC: main Index: 2 Type: DirectCall

‎bolt/test/runtime/AArch64/adrrelaxationpass.s

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
# RUN: %s -o %t.o
88
# RUN: %clang %cflags %t.o -o %t.exe -Wl,-q
99
# RUN: llvm-bolt %t.exe -o %t.bolt --adr-relaxation=true
10-
# RUN: llvm-objdump -d --disassemble-symbols=main %t.bolt | FileCheck %s
10+
# RUN: llvm-objdump --no-print-imm-hex -d --disassemble-symbols=main %t.bolt | FileCheck %s
1111
# RUN: %t.bolt
1212

1313
.data

‎clang-tools-extra/clang-doc/BitcodeReader.cpp

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -368,28 +368,27 @@ template <typename T> llvm::Expected<CommentInfo *> getCommentInfo(T I) {
368368
}
369369

370370
template <> llvm::Expected<CommentInfo *> getCommentInfo(FunctionInfo *I) {
371-
I->Description.emplace_back();
372-
return &I->Description.back();
371+
return &I->Description.emplace_back();
373372
}
374373

375374
template <> llvm::Expected<CommentInfo *> getCommentInfo(NamespaceInfo *I) {
376-
I->Description.emplace_back();
377-
return &I->Description.back();
375+
return &I->Description.emplace_back();
378376
}
379377

380378
template <> llvm::Expected<CommentInfo *> getCommentInfo(RecordInfo *I) {
381-
I->Description.emplace_back();
382-
return &I->Description.back();
379+
return &I->Description.emplace_back();
383380
}
384381

385382
template <> llvm::Expected<CommentInfo *> getCommentInfo(MemberTypeInfo *I) {
386-
I->Description.emplace_back();
387-
return &I->Description.back();
383+
return &I->Description.emplace_back();
388384
}
389385

390386
template <> llvm::Expected<CommentInfo *> getCommentInfo(EnumInfo *I) {
391-
I->Description.emplace_back();
392-
return &I->Description.back();
387+
return &I->Description.emplace_back();
388+
}
389+
390+
template <> llvm::Expected<CommentInfo *> getCommentInfo(TypedefInfo *I) {
391+
return &I->Description.emplace_back();
393392
}
394393

395394
template <> llvm::Expected<CommentInfo *> getCommentInfo(CommentInfo *I) {

‎clang-tools-extra/clang-doc/BitcodeWriter.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -432,6 +432,8 @@ void ClangDocBitcodeWriter::emitBlock(const TypedefInfo &T) {
432432
emitRecord(T.Name, TYPEDEF_NAME);
433433
for (const auto &N : T.Namespace)
434434
emitBlock(N, FieldId::F_namespace);
435+
for (const auto &CI : T.Description)
436+
emitBlock(CI);
435437
if (T.DefLoc)
436438
emitRecord(*T.DefLoc, TYPEDEF_DEFLOCATION);
437439
emitRecord(T.IsUsing, TYPEDEF_IS_USING);

‎clang-tools-extra/clang-doc/Generators.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ void Generator::addInfoToIndex(Index &Idx, const doc::Info *Info) {
6565
for (const auto &R : llvm::reverse(Info->Namespace)) {
6666
// Look for the current namespace in the children of the index I is
6767
// pointing.
68-
auto It = std::find(I->Children.begin(), I->Children.end(), R.USR);
68+
auto It = llvm::find(I->Children, R.USR);
6969
if (It != I->Children.end()) {
7070
// If it is found, just change I to point the namespace reference found.
7171
I = &*It;
@@ -79,7 +79,7 @@ void Generator::addInfoToIndex(Index &Idx, const doc::Info *Info) {
7979
// Look for Info in the vector where it is supposed to be; it could already
8080
// exist if it is a parent namespace of an Info already passed to this
8181
// function.
82-
auto It = std::find(I->Children.begin(), I->Children.end(), Info->USR);
82+
auto It = llvm::find(I->Children, Info->USR);
8383
if (It == I->Children.end()) {
8484
// If it is not in the vector it is inserted
8585
I->Children.emplace_back(Info->USR, Info->extractName(), Info->IT,

‎clang-tools-extra/clang-doc/Representation.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ struct TypedefInfo : public SymbolInfo {
365365
// using MyVector = std::vector<int>
366366
// False means it's a C-style typedef:
367367
// typedef std::vector<int> MyVector;
368-
bool IsUsing;
368+
bool IsUsing = false;
369369
};
370370

371371
struct BaseRecordInfo : public RecordInfo {

‎clang-tools-extra/clang-tidy/misc/ConfusableIdentifierCheck.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,7 @@ std::string ConfusableIdentifierCheck::skeleton(StringRef Name) {
7878
UTF8 *BufferStart = std::begin(Buffer);
7979
UTF8 *IBuffer = BufferStart;
8080
const UTF32 *ValuesStart = std::begin(Where->values);
81-
const UTF32 *ValuesEnd =
82-
std::find(std::begin(Where->values), std::end(Where->values), '\0');
81+
const UTF32 *ValuesEnd = llvm::find(Where->values, '\0');
8382
if (ConvertUTF32toUTF8(&ValuesStart, ValuesEnd, &IBuffer,
8483
std::end(Buffer),
8584
strictConversion) != conversionOK) {

0 commit comments

Comments
 (0)