Skip to content

Commit e9a53ab

Browse files
committed
DRAFT: Avoid potential ambiguity in UrReturnHelper
1 parent d130196 commit e9a53ab

File tree

2 files changed

+14
-8
lines changed

2 files changed

+14
-8
lines changed

sycl/cmake/modules/FetchUnifiedRuntime.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ if(SYCL_UR_USE_FETCH_CONTENT)
116116
CACHE PATH "Path to external '${name}' adapter source dir" FORCE)
117117
endfunction()
118118

119-
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
119+
set(UNIFIED_RUNTIME_REPO "https://github.com/hvdijk/unified-runtime.git")
120120
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/UnifiedRuntimeTag.cmake)
121121

122122
set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
1-
# commit 3d58884b4939d9bd095c917f8dd823ac8486684c
2-
# Merge: 6ade245e b0bd146a
3-
# Author: aarongreig <[email protected]>
4-
# Date: Thu Oct 31 14:05:55 2024 +0000
5-
# Merge pull request #2228 from nrspruit/copy_engine_refactor
6-
# [L0] Refactor Copy Engine Usage checks for Performance
7-
set(UNIFIED_RUNTIME_TAG 3d58884b4939d9bd095c917f8dd823ac8486684c)
1+
# commit f6d00b8a95ddc41e17ac2faeba13afacd48252d2
2+
# Author: Harald van Dijk <[email protected]>
3+
# Date: Fri Nov 1 11:08:39 2024 +0000
4+
#
5+
# Avoid potential ambiguity in UrReturnHelper
6+
#
7+
# If UrReturnHelper's operator() is explicitly called as
8+
# operator()<T>(...), there is a potential for ambiguity when the
9+
# specified RetType and the inferred T are the same: this is ambiguous
10+
# with the version of operator() where only T is a template parameter,
11+
# and T is specified explicitly. We already have code that explicitly
12+
# calls operator()<T>(...), so prevent this from becoming a problem.
13+
set(UNIFIED_RUNTIME_TAG f6d00b8a95ddc41e17ac2faeba13afacd48252d2)

0 commit comments

Comments
 (0)