[UR][HIP][CUDA] Update UR CTS disabled tests (#18396)

Most of these tests were already passing. One of them was just missing a
simple check in the HIP adapter.

Author: npmiller

unified-runtime/source/adapters/hip/kernel.cpp

@@ -178,6 +178,8 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelSuggestMaxCooperativeGroupCountExp(
 UR_APIEXPORT ur_result_t UR_APICALL urKernelSetArgValue(
     ur_kernel_handle_t hKernel, uint32_t argIndex, size_t argSize,
     const ur_kernel_arg_value_properties_t *, const void *pArgValue) {
+  UR_ASSERT(argSize, UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE);
+
   ur_result_t Result = UR_RESULT_SUCCESS;
   try {
     hKernel->setKernelArg(argIndex, argSize, pArgValue);

unified-runtime/test/conformance/enqueue/urEnqueueKernelLaunch.cpp

@@ -633,10 +633,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
     uur::deviceTestWithParamPrinter<uur::BoolTestParam>);
 
 TEST_P(urEnqueueKernelLaunchUSMLinkedList, Success) {
-  if (use_pool) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
-
   ur_device_usm_access_capability_flags_t shared_usm_flags = 0;
   ASSERT_SUCCESS(
       uur::GetDeviceUSMSingleSharedSupport(device, shared_usm_flags));

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferCopyRect.cpp

@@ -79,13 +79,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
 
 TEST_P(urEnqueueMemBufferCopyRectTestWithParam, Success) {
   const auto name = getParam().name;
-  if (name.find("copy_row_2D") != std::string::npos) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
-
-  if (name.find("copy_3D_2D") != std::string::npos) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
 
   UUR_KNOWN_FAILURE_ON(uur::LevelZero{}, uur::LevelZeroV2{});
 

unified-runtime/test/conformance/enqueue/urEnqueueMemBufferWriteRect.cpp

@@ -78,15 +78,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
     uur::printRectTestString<urEnqueueMemBufferWriteRectTestWithParam>);
 
 TEST_P(urEnqueueMemBufferWriteRectTestWithParam, Success) {
-  const auto name = getParam().name;
-  if (name.find("write_row_2D") != std::string::npos) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
-
-  if (name.find("write_3D_2D") != std::string::npos) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
-
   UUR_KNOWN_FAILURE_ON(uur::LevelZero{}, uur::LevelZeroV2{});
 
   // Unpack the parameters.

unified-runtime/test/conformance/exp_command_buffer/rect_write.cpp

@@ -117,19 +117,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
         urCommandBufferAppendMemBufferWriteRectTestWithParam>);
 
 TEST_P(urCommandBufferAppendMemBufferWriteRectTestWithParam, Success) {
-  const auto name = getParam().name;
-
-  // This file is based on enqueue/urEnqueueMemBufferWriteRect.cpp
-  // because of this, these checks are present here,
-  // since there were present in original code
-  if (name.find("write_row_2D") != std::string::npos) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
-
-  if (name.find("write_3D_2D") != std::string::npos) {
-    UUR_KNOWN_FAILURE_ON(uur::HIP{});
-  }
-
   UUR_KNOWN_FAILURE_ON(uur::LevelZero{});
 
   // Zero it to begin with since the write may not cover the whole buffer.

unified-runtime/test/conformance/kernel/urKernelGetInfo.cpp

@@ -199,8 +199,6 @@ TEST_P(urKernelGetInfoTest, SuccessAttributes) {
 }
 
 TEST_P(urKernelGetInfoTest, SuccessNumRegs) {
-  UUR_KNOWN_FAILURE_ON(uur::HIP{});
-
   const ur_kernel_info_t property_name = UR_KERNEL_INFO_NUM_REGS;
   size_t property_size = 0;
 
@@ -217,7 +215,7 @@ TEST_P(urKernelGetInfoTest, SuccessNumRegs) {
 }
 
 TEST_P(urKernelGetInfoTest, SuccessSpillMemSize) {
-  UUR_KNOWN_FAILURE_ON(uur::HIP{}, uur::OpenCL{});
+  UUR_KNOWN_FAILURE_ON(uur::OpenCL{});
 
   ur_kernel_info_t property_name = UR_KERNEL_INFO_SPILL_MEM_SIZE;
   size_t property_size = 0;

unified-runtime/test/conformance/kernel/urKernelSetArgValue.cpp

@@ -48,7 +48,7 @@ TEST_P(urKernelSetArgValueTest, InvalidKernelArgumentIndex) {
 }
 
 TEST_P(urKernelSetArgValueTest, InvalidKernelArgumentSize) {
-  UUR_KNOWN_FAILURE_ON(uur::HIP{}, uur::OpenCL{"Intel(R) UHD Graphics 770"});
+  UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) UHD Graphics 770"});
 
   ASSERT_EQ_RESULT(UR_RESULT_ERROR_INVALID_KERNEL_ARGUMENT_SIZE,
                    urKernelSetArgValue(kernel, 2, 0, nullptr, &arg_value));

unified-runtime/test/conformance/memory/urMemImageCreate.cpp

@@ -92,10 +92,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
 TEST_P(urMemImageCreateTestWith1DMemoryTypeParam, Success) {
   UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) FPGA"});
 
-  if (getParam() == UR_MEM_TYPE_IMAGE1D_ARRAY) {
-    UUR_KNOWN_FAILURE_ON(uur::CUDA{});
-  }
-
   ur_image_desc_t image_desc_with_param{
       UR_STRUCTURE_TYPE_IMAGE_DESC, ///< [in] type of this structure
       nullptr,    ///< [in][optional] pointer to extension-specific structure
@@ -128,10 +124,6 @@ UUR_DEVICE_TEST_SUITE_WITH_PARAM(
 TEST_P(urMemImageCreateTestWith2DMemoryTypeParam, Success) {
   UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) FPGA"});
 
-  if (getParam() == UR_MEM_TYPE_IMAGE2D_ARRAY) {
-    UUR_KNOWN_FAILURE_ON(uur::CUDA{});
-  }
-
   ur_image_desc_t image_desc_with_param{
       UR_STRUCTURE_TYPE_IMAGE_DESC, ///< [in] type of this structure
       nullptr,    ///< [in][optional] pointer to extension-specific structure

unified-runtime/test/conformance/program/urProgramGetInfo.cpp

@@ -178,8 +178,6 @@ TEST_P(urProgramGetInfoTest, SuccessBinaries) {
 }
 
 TEST_P(urProgramGetInfoTest, SuccessNumKernels) {
-  UUR_KNOWN_FAILURE_ON(uur::HIP{});
-
   size_t property_size = 0;
   const ur_program_info_t property_name = UR_PROGRAM_INFO_NUM_KERNELS;