Skip to content

Commit ee0707b

Browse files
committed
Remove fallback macro in tests and disable known failing L0 cases
Signed-off-by: Larsen, Steffen <[email protected]>
1 parent 8cc1567 commit ee0707b

17 files changed

+32
-18
lines changed

sycl/test-e2e/Assert/assert_in_kernels.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,12 @@
55
//
66
// XFAIL: (opencl && gpu)
77
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
8+
//
9+
// L0 does not currently abort after synchronizing with a failing kernel.
10+
// UNSUPPORTED: level_zero
11+
// UNSUPPORTED-TRACKER: GSD-11097
812

9-
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -o %t.out
13+
// RUN: %{build} -o %t.out
1014
// Shouldn't fail on ACC as fallback assert isn't enqueued there
1115
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
1216
//

sycl/test-e2e/Assert/assert_in_kernels_non_native.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// REQUIRES: linux && preview-breaking-changes-supported && !aspect-ext_oneapi_native_assert
22
//
3+
// L0 does not currently abort after synchronizing with a failing kernel.
4+
// UNSUPPORTED: level_zero
5+
// UNSUPPORTED-TRACKER: GSD-11097
6+
//
37
// RUN: %{build} -fpreview-breaking-changes -o %t.out
48
// RUN: %{run} %t.out | FileCheck %s
59
//

sycl/test-e2e/Assert/assert_in_kernels_win.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// REQUIRES: windows
2-
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -o %t.out
2+
// RUN: %{build} -o %t.out
33
// Shouldn't fail on ACC as fallback assert isn't enqueued there
44
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
55
//

sycl/test-e2e/Assert/assert_in_multiple_tus.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,10 @@
88
//
99
// XFAIL: (opencl && gpu)
1010
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
11-
12-
// Test requires at least this version of the Intel GPU driver on Arc.
13-
// REQUIRES-INTEL-DRIVER: lin: 31294
11+
//
12+
// L0 does not currently abort after synchronizing with a failing kernel.
13+
// UNSUPPORTED: level_zero
14+
// UNSUPPORTED-TRACKER: GSD-11097
1415

1516
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -I %S/Inputs %S/Inputs/kernels_in_file2.cpp -o %t.out
1617
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}

sycl/test-e2e/Assert/assert_in_multiple_tus_one_ndebug.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
// XFAIL: (opencl && gpu)
1010
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
1111

12-
// RUN: %clangxx -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -fsycl %{sycl_target_opts} -DDEFINE_NDEBUG_INFILE2 -I %S/Inputs %S/assert_in_multiple_tus.cpp %S/Inputs/kernels_in_file2.cpp -o %t.out
12+
// RUN: %clangxx -fsycl %{sycl_target_opts} -DDEFINE_NDEBUG_INFILE2 -I %S/Inputs %S/assert_in_multiple_tus.cpp %S/Inputs/kernels_in_file2.cpp -o %t.out
1313
// Shouldn't fail on ACC as fallback assert isn't enqueued there
1414
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
1515
//

sycl/test-e2e/Assert/assert_in_multiple_tus_one_ndebug_win.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// REQUIRES: windows
2-
// RUN: %clangxx -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -fsycl %{sycl_target_opts} -DDEFINE_NDEBUG_INFILE2 -I %S/Inputs %S/assert_in_multiple_tus.cpp %S/Inputs/kernels_in_file2.cpp -o %t.out
2+
// RUN: %clangxx -fsycl %{sycl_target_opts} -DDEFINE_NDEBUG_INFILE2 -I %S/Inputs %S/assert_in_multiple_tus.cpp %S/Inputs/kernels_in_file2.cpp -o %t.out
33
// Shouldn't fail on ACC as fallback assert isn't enqueued there
44
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
55
//

sycl/test-e2e/Assert/assert_in_multiple_tus_win.cpp

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
// REQUIRES: windows
2-
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -I %S/Inputs %S/Inputs/kernels_in_file2.cpp -o %t.out
2+
//
3+
// L0 does not currently abort after synchronizing with a failing kernel.
4+
// UNSUPPORTED: level_zero
5+
// UNSUPPORTED-TRACKER: GSD-11097
6+
//
7+
// RUN: %{build} -I %S/Inputs %S/Inputs/kernels_in_file2.cpp -o %t.out
38
// Shouldn't fail on ACC as fallback assert isn't enqueued there
49
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
510
//

sycl/test-e2e/Assert/assert_in_one_kernel.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
// XFAIL: (opencl && gpu)
77
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364
88

9-
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -o %t.out
9+
// RUN: %{build} -o %t.out
1010
// Shouldn't fail on ACC as fallback assert isn't enqueued there
1111
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
1212
//

sycl/test-e2e/Assert/assert_in_one_kernel_win.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
// REQUIRES: windows
2-
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -o %t.out
2+
// RUN: %{build} -o %t.out
33
// Shouldn't fail on ACC as fallback assert isn't enqueued there
44
// RUN: %{run} %t.out &> %t.txt ; FileCheck %s --input-file %t.txt %if fpga %{ --check-prefix=CHECK-ACC %}
55
//

sycl/test-e2e/Assert/assert_in_simultaneous_kernels.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// REQUIRES: linux
22
// FIXME: Flaky on HIP and cuda
33
// UNSUPPORTED: hip || cuda
4-
// RUN: %{build} -DSYCL_FALLBACK_ASSERT=1 -Wno-error=#warnings -o %t.out %threads_lib
4+
// RUN: %{build} -o %t.out %threads_lib
55
//
66
// XFAIL: (opencl && gpu)
77
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/11364

0 commit comments

Comments
 (0)