Skip to content

Commit fa8d006

Browse files
committed
archive unitrace results instead
1 parent 0f7cf27 commit fa8d006

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

devops/actions/run-tests/benchmark/action.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,8 @@ runs:
208208
--preset "$PRESET" \
209209
--timestamp-override "$SAVE_TIMESTAMP" \
210210
--detect-version sycl,compute_runtime \
211-
${{ inputs.enable_unitrace == 'true' && '--unitrace --flamegraph inclusive' || '' }}
211+
--flamegraph inclusive \
212+
${{ inputs.enable_unitrace == 'true' && '--unitrace inclusive' || '' }}
212213

213214
echo "-----"
214215
python3 ./devops/scripts/benchmarks/compare.py to_hist \
@@ -283,6 +284,12 @@ runs:
283284
--dry-run
284285
cd -
285286
done
287+
- name: Archive unitrace results
288+
if: inputs.enable_unitrace == 'true'
289+
uses: actions/upload-artifact@v4
290+
with:
291+
name: Unitrace results ${{ github.run_id }} (${{ env.SAVE_NAME }})
292+
path: ./llvm-ci-perf-results/traces
286293
- name: Archive benchmark results
287294
if: always()
288295
uses: actions/upload-artifact@v4

devops/scripts/benchmarks/benches/base.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,9 @@ def run_bench(
153153
if extra_trace_opt is None:
154154
extra_trace_opt = []
155155
unitrace_output, command = get_unitrace().setup(
156-
self.name(), command, extra_trace_opt
156+
self.name().replace(':', '='), command, extra_trace_opt
157157
)
158+
# ':' is a problematic character for Github actions/artifacts
158159
log.debug(f"Unitrace output: {unitrace_output}")
159160
log.debug(f"Unitrace command: {' '.join(command)}")
160161

0 commit comments

Comments
 (0)