Skip to content

Commit fbc2c8f

Browse files
committed
[InstSimplify] fold X +nnan Inf
If we exclude NaN (and therefore the opposite Inf), anything plus Inf is Inf: https://alive2.llvm.org/ce/z/og3dj9
1 parent 58167f6 commit fbc2c8f

File tree

2 files changed

+17
-15
lines changed

2 files changed

+17
-15
lines changed

llvm/lib/Analysis/InstructionSimplify.cpp

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5245,14 +5245,18 @@ simplifyFAddInst(Value *Op0, Value *Op1, FastMathFlags FMF,
52455245
if (!isDefaultFPEnvironment(ExBehavior, Rounding))
52465246
return nullptr;
52475247

5248-
// With nnan: -X + X --> 0.0 (and commuted variant)
5249-
// We don't have to explicitly exclude infinities (ninf): INF + -INF == NaN.
5250-
// Negative zeros are allowed because we always end up with positive zero:
5251-
// X = -0.0: (-0.0 - (-0.0)) + (-0.0) == ( 0.0) + (-0.0) == 0.0
5252-
// X = -0.0: ( 0.0 - (-0.0)) + (-0.0) == ( 0.0) + (-0.0) == 0.0
5253-
// X = 0.0: (-0.0 - ( 0.0)) + ( 0.0) == (-0.0) + ( 0.0) == 0.0
5254-
// X = 0.0: ( 0.0 - ( 0.0)) + ( 0.0) == ( 0.0) + ( 0.0) == 0.0
52555248
if (FMF.noNaNs()) {
5249+
// With nnan: X + {+/-}Inf --> {+/-}Inf
5250+
if (match(Op1, m_Inf()))
5251+
return Op1;
5252+
5253+
// With nnan: -X + X --> 0.0 (and commuted variant)
5254+
// We don't have to explicitly exclude infinities (ninf): INF + -INF == NaN.
5255+
// Negative zeros are allowed because we always end up with positive zero:
5256+
// X = -0.0: (-0.0 - (-0.0)) + (-0.0) == ( 0.0) + (-0.0) == 0.0
5257+
// X = -0.0: ( 0.0 - (-0.0)) + (-0.0) == ( 0.0) + (-0.0) == 0.0
5258+
// X = 0.0: (-0.0 - ( 0.0)) + ( 0.0) == (-0.0) + ( 0.0) == 0.0
5259+
// X = 0.0: ( 0.0 - ( 0.0)) + ( 0.0) == ( 0.0) + ( 0.0) == 0.0
52565260
if (match(Op0, m_FSub(m_AnyZeroFP(), m_Specific(Op1))) ||
52575261
match(Op1, m_FSub(m_AnyZeroFP(), m_Specific(Op0))))
52585262
return ConstantFP::getNullValue(Op0->getType());

llvm/test/Transforms/InstSimplify/floating-point-arithmetic.ll

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -818,40 +818,38 @@ define float @maxnum_with_pos_one_op(float %a) {
818818

819819
define double @fadd_nnan_inf_op0(double %x) {
820820
; CHECK-LABEL: @fadd_nnan_inf_op0(
821-
; CHECK-NEXT: [[R:%.*]] = fadd nnan double 0x7FF0000000000000, [[X:%.*]]
822-
; CHECK-NEXT: ret double [[R]]
821+
; CHECK-NEXT: ret double 0x7FF0000000000000
823822
;
824823
%r = fadd nnan double 0x7ff0000000000000, %x
825824
ret double %r
826825
}
827826

828827
define double @fadd_nnan_inf_op1(double %x) {
829828
; CHECK-LABEL: @fadd_nnan_inf_op1(
830-
; CHECK-NEXT: [[R:%.*]] = fadd nnan double [[X:%.*]], 0x7FF0000000000000
831-
; CHECK-NEXT: ret double [[R]]
829+
; CHECK-NEXT: ret double 0x7FF0000000000000
832830
;
833831
%r = fadd nnan double %x, 0x7ff0000000000000
834832
ret double %r
835833
}
836834

837835
define <2 x double> @fadd_nnan_neginf_op1(<2 x double> %x) {
838836
; CHECK-LABEL: @fadd_nnan_neginf_op1(
839-
; CHECK-NEXT: [[R:%.*]] = fadd nnan <2 x double> [[X:%.*]], <double 0xFFF0000000000000, double poison>
840-
; CHECK-NEXT: ret <2 x double> [[R]]
837+
; CHECK-NEXT: ret <2 x double> <double 0xFFF0000000000000, double poison>
841838
;
842839
%r = fadd nnan <2 x double> %x, <double 0xfff0000000000000, double poison>
843840
ret <2 x double> %r
844841
}
845842

846843
define double @fadd_nnan_neginf_op0(double %x) {
847844
; CHECK-LABEL: @fadd_nnan_neginf_op0(
848-
; CHECK-NEXT: [[R:%.*]] = fadd nnan double 0xFFF0000000000000, [[X:%.*]]
849-
; CHECK-NEXT: ret double [[R]]
845+
; CHECK-NEXT: ret double 0xFFF0000000000000
850846
;
851847
%r = fadd nnan double 0xfff0000000000000, %x
852848
ret double %r
853849
}
854850

851+
; negative test - requires nnan
852+
855853
define double @fadd_inf_op0(double %x) {
856854
; CHECK-LABEL: @fadd_inf_op0(
857855
; CHECK-NEXT: [[R:%.*]] = fadd double 0x7FF0000000000000, [[X:%.*]]

0 commit comments

Comments
 (0)