[SYCL][NATIVE_CPU] Fill in any SYCL functions which require mapping to mux #15592
+365
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o mux Native cpu can make calls to mux builtins such as shuffle which are ABI compliant but are not what is expected by ock passes. This fixes them up by remove the vector versions from libnativecpu.cpp and using a pass to convert from parameters which relate to the ABI to calling the mux functions with the set interface unaffected by the ABI. This currently only handle a small number of cases for shuffle such as when a vector i2 is replaced with double or byval is used. It will be expanded over time as needed.
PietroGhg
approved these changes
Oct 4, 2024
|
@intel/llvm-gatekeepers please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native cpu can make calls to mux builtins such as shuffle which are ABI compliant but are not what is expected by ock passes. This fixes them up by remove the vector versions from libnativecpu.cpp and using a pass to convert from parameters which relate to the ABI to calling the mux functions with the set interface unaffected by the ABI.
This currently only handle a small number of cases for shuffle such as when a vector i2 is replaced with double or byval is used. It will be expanded over time as needed.