Skip to content

Conversation

@GeorgeWeb
Copy link
Contributor

@GeorgeWeb GeorgeWeb commented Oct 4, 2024

This PR fixes a typo in the sycl target arch macros for Nvidia by renaming __SYCL_TARGET_NVIDIA_GPU_SM to __SYCL_TARGET_NVIDIA_GPU_SM_. Resolves issue #15545.

@GeorgeWeb
Copy link
Contributor Author

GeorgeWeb commented Oct 4, 2024

There are already existing (positive) Driver tests for these macros in clang/test/Driver/sycl-oneapi-gpu-nvidia.cpp that we pass the correct __SYCL_TARGET_NVIDIA_GPU_<SM_VERSION>__ define to the clang -cc1 invocation.

@GeorgeWeb GeorgeWeb marked this pull request as ready for review October 6, 2024 15:29
@GeorgeWeb GeorgeWeb requested a review from a team as a code owner October 6, 2024 15:29
@GeorgeWeb GeorgeWeb requested a review from bso-intel October 6, 2024 15:29
@GeorgeWeb
Copy link
Contributor Author

Closing as duplicate of #15615

@GeorgeWeb GeorgeWeb closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant