Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Oct 21, 2024

We need a newer driver for the PVC version of the test.

@sarnex sarnex marked this pull request as ready for review October 21, 2024 21:12
@sarnex sarnex requested a review from a team as a code owner October 21, 2024 21:12
@sarnex sarnex changed the title [SYCL][ESIMD][E2E] Add driver requirement to sqrt test [SYCL][ESIMD][E2E] Add driver requirement to sqrt tests Oct 22, 2024
@sarnex
Copy link
Contributor Author

sarnex commented Oct 22, 2024

@fineg74 Mind taking a second look at this? I had to rework the change because actually all 4 ext_math tests were failing not just the original one I changed. The original test I modified was already PVC only so adding a driver req there was fine, but the other 3 tests are not PVC only, so we would be disabling testing on all platforms until the new driver if I added the req there which would be a major loss of coverage, so I made PVC versions of the test that have the driver req and non-PVC versions that don't (or have some other existing driver req)

@sarnex sarnex merged commit 74f82de into intel:sycl Oct 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants