Skip to content

Conversation

@maarquitos14
Copy link
Contributor

No description provided.

uditagarwal97 and others added 9 commits October 28, 2024 17:23
…YCL caches (#15822)

Currently, we use SYCL_CACHE_TRACE for events in persistent cache only.
This PR repurposes SYCL_CACHE_TRACE to also enable tracing of in-memory
cache and kernel_compiler.

After this change, SYCL_CACHE_TRACE will accept the following bit-masks:

| Bit-mask | Corresponding cache tracing |
| ------ | ----------- |
| 0x01 | Enable tracing of persistent cache |
| 0x02 | Enable tracing of in-memory cache |
| 0x04 | Enable tracing of `kernel_compiler` cache |


Any valid combination of the above bit-masks can be used to
enable/disable tracing of the corresponding caches.

---------

Co-authored-by: Steffen Larsen <[email protected]>
…p` (#15900)

We've been using simpler way to define them since
#12831 but somehow that extension
missed that.
)

This should make it easier to follow the logic and understand if
template parameters (like `PropertyT`) refer to keys or values.
Simplified key creation was introduced in
#12831 but this one was never updated.
I think it happened because this property never defined `PropKind` enum
entry and I'm not even sure how it worked or what are scenarios where it
was broken.

Regardless, fix and unify with all other properties with this PR.
Fixes: #15829

**Problem**
`--offload-compress` is being used by HIP in `clang-offload-bundler` and
by us in `clang-offload-wrapper`. When we use ` --offload-compress` for
SYCL offloading to HIP, the device images gets compressed twice: once in
`offload-bundler` and then in `offload-wrapper`.

**~Solution~ Workaround** 
This PR intends to disable compression in `clang-offload-bundler` when
offloading to HIP.
…ified CFLAGS (#15870)

Add an new function in libdevice CMake to provide a way to pass
arbitrary compiling flags when building a device library file. This is
preparatory work to add AOT device asan library targeting for different
GPU/CPU platforms.

Signed-off-by: jinge90 <[email protected]>
That particular spelling had been introduced as part of an Intel extension to support sub-groups in SYCL 1.2.1 before they became a core feature of SYCL 2020.

The extension has been deprecated for a while and no one should use that legacy spelling anymore. The official SYCL 2020 spelling should be used instead (with `sycl::` namespace).
@bader bader deleted the temp branch October 30, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants