[DeviceASAN] Enable e2e test "private_nullptr.cpp" #15995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
changed the title
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@intel/llvm-gatekeepers, the failed test is unrelated to this PR, please merge. Thank you |
yingcong-wu
approved these changes
Nov 8, 2024
zhaomaosu
approved these changes
Nov 8, 2024
Contributor
|
Hi @AllanZyne! The failing test is not unrelated. It tracks all unspecified XFAILs we have, i.e. ones without XFAIL-TRACKER. Since you're removing such a case, you also need to remove the corresponding test from the list (you will likely have the change the following line to |
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
AllanZyne
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
Thanks, fixed it. @steffenlarsen |
steffenlarsen
added a commit
that referenced
this pull request
Nov 14, 2024
This reverts commit c001520.
sarnex
pushed a commit
that referenced
this pull request
Nov 14, 2024
Reverts #15995 @AllanZyne - It looks like this still fails on Arc in post-commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.