Skip to content

[SYCL][Bindless][E2E] fix double free in vulkan interop unsampled test #16027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 12, 2024
Merged

[SYCL][Bindless][E2E] fix double free in vulkan interop unsampled test #16027

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7ac737a
[SYCL][Bindless][E2E] fix double free in vulkan interop unsampled test
cppchedy Sep 27, 2024
fff8e33
fix tag update
cppchedy Nov 13, 2024
f989c3f
update tag
cppchedy Nov 13, 2024
5ed6aee
Merge branch 'sycl' into chedy/fix-mipmap-leak
cppchedy Nov 28, 2024
e33139e
update UR tag
cppchedy Nov 28, 2024
9eb28d6
fix
cppchedy Nov 28, 2024
fb7ce66
Merge branch 'sycl' into chedy/fix-mipmap-leak
ProGTX Dec 6, 2024
4e31a5f
Merge branch 'sycl' into chedy/fix-mipmap-leak
ProGTX Dec 6, 2024
2f2a758
Merge branch 'sycl' into chedy/fix-mipmap-leak
ProGTX Dec 11, 2024
99c111c
Use correct UR repo
ProGTX Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/cmake/modules/FetchUnifiedRuntime.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ if(SYCL_UR_USE_FETCH_CONTENT)
endfunction()

set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/modules/UnifiedRuntimeTag.cmake)
set(UNIFIED_RUNTIME_TAG 698cd9974c18874bf6a7e9ec78507c30b9deeca7)
Copy link
Contributor

@DBDuncan DBDuncan Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe now you need to instead edit UnifiedRuntimeTag.cmake with the new commit and leave this line unedited.

Copy link
Contributor Author

@cppchedy cppchedy Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah. thank you. I missed this change. fixed now


set(UMF_BUILD_EXAMPLES OFF CACHE INTERNAL "EXAMPLES")
# Due to the use of dependentloadflag and no installer for UMF and hwloc we need
Expand Down
2 changes: 1 addition & 1 deletion sycl/test-e2e/bindless_images/vulkan_interop/unsampled_images.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ void cleanup_test(sycl::context &ctxt, sycl::device &dev, handles_t handles) {
syclexp::destroy_image_handle(handles.output, dev, ctxt);
syclexp::free_image_mem(handles.input_mem_handle_1,
syclexp::image_type::standard, dev, ctxt);
syclexp::free_image_mem(handles.input_mem_handle_1,
syclexp::free_image_mem(handles.input_mem_handle_2,
syclexp::image_type::standard, dev, ctxt);
syclexp::free_image_mem(handles.output_mem_handle,
syclexp::image_type::standard, dev, ctxt);
Expand Down
Loading