Skip to content

Conversation

@RossBrunton
Copy link
Contributor

@RossBrunton RossBrunton commented Nov 11, 2024

Pre-commit MR for: oneapi-src/unified-runtime#2222

@RossBrunton RossBrunton marked this pull request as ready for review November 15, 2024 15:07
@RossBrunton RossBrunton requested a review from a team as a code owner November 15, 2024 15:07
@callumfare
Copy link
Contributor

@intel/llvm-gatekeepers Please merge

@sarnex sarnex merged commit 27dab62 into intel:sycl Nov 15, 2024
12 checks passed
martygrant pushed a commit that referenced this pull request Dec 13, 2024
~~Update the UR tag to include
oneapi-src/unified-runtime#2273 fixing
`queue::fill` for the CUDA and HIP backends. It was previously producing
incorrect outputs for any pattern size other than 1, 2, or a multiple of
4 bytes. A new optimisation is also added which speeds up the fill
greatly if the pattern equals to the first word repeated throughout
(e.g. all zeros). See the UR PR for more details.~~

_The UR tag update was collected in
#16040 so now this PR only adds an e2e
test as stated below._

Add a new e2e test to validate `queue::fill` outputs for any pattern
size between 1 and 32 bytes. This test fails for CUDA and HIP before the
UR change and passes with this PR. Other backends already worked
correctly.
@RossBrunton RossBrunton deleted the ross/cfi branch February 19, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants