[SYCL][NFCI] Unify program build paths in program manager #16113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
commented
Nov 18, 2024
Comment on lines
867
to
879
| device_image_plain DevImagePlain = | ||
| getDeviceImageFromBinaryImage(BinImg, Context, Device); | ||
| const std::shared_ptr<detail::device_image_impl> &DeviceImageImpl = | ||
| detail::getSyclObjImpl(DevImagePlain); | ||
|
|
||
| SerializedObj ImgSpecConsts = | ||
| DeviceImageImpl->get_spec_const_blob_ref(); | ||
|
|
||
| ur_program_handle_t NativePrg = | ||
| createURProgram(*BinImg, Context, {Device}); | ||
| ur_program_handle_t NativePrg = createURProgram(*BinImg, Context, Devs); | ||
|
|
||
| if (BinImg->supportsSpecConstants()) | ||
| setSpecializationConstants(DeviceImageImpl, NativePrg, Adapter); |
Contributor
Author
There was a problem hiding this comment.
Note: this spec constant part was intentionally removed since it did nothing except enable ITT annotations because the newly created device image contained no spec constant values.
sergey-semenov
changed the title
aelovikov-intel
approved these changes
Nov 18, 2024
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
I assume it's mostly mechanical unification of two almost identical methods with further simplifications delayed till later PRs.
If some changes don't fall into that description, please tag specific lines for more thorough review, otherwise thanks for the refactoring!
uditagarwal97
approved these changes
Nov 18, 2024
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
Looks good to me too. Just one minor comment.
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.