Skip to content

[SYCL][E2E] Initialize arch_flag to an empty string by default #16200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[SYCL][E2E] Initialize arch_flag to an empty string by default #16200

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4229c2a
Initialize arch_flag by default
ayylol Nov 27, 2024
7d3a72c
Add comment for variable
ayylol Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions sycl/test-e2e/lit.cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
case "build-only":
config.test_mode = "build-only"
config.sycl_devices = []
arch_flag = ""
case "full":
config.test_mode = "full"
config.available_features.add("run-mode")
Expand Down Expand Up @@ -657,6 +656,8 @@ def open_check_file(file_name):
# discovered already.
config.sycl_dev_features = {}

# Architecture flag for compiling for AMD HIP devices. Empty otherwise.
arch_flag = ""
# Version of the driver for a given device. Empty for non-Intel devices.
config.intel_driver_ver = {}
for sycl_device in config.sycl_devices:
Expand Down Expand Up @@ -798,9 +799,6 @@ def open_check_file(file_name):
)
elif be == "hip" and config.hip_platform == "NVIDIA":
config.available_features.add("hip_nvidia")
arch_flag = ""
else:
arch_flag = ""

config.sycl_dev_features[sycl_device] = features.union(config.available_features)
if is_intel_driver:
Expand Down