Skip to content

[SYCL] Refactor check_device_code/vector LIT tests #17153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 25, 2025
Merged

[SYCL] Refactor check_device_code/vector LIT tests #17153

merged 2 commits into from
Feb 25, 2025

Conversation

@uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Feb 25, 2025 •
edited
Loading

This PR split check_device_code/vector LIT tests into two: one without preview-breaking-flag and one with the flag.
This would increase test coverage and also make it easier for us to switch tests during ABI-breaking window.

@uditagarwal97 uditagarwal97 self-assigned this Feb 25, 2025
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner February 25, 2025 00:52
@uditagarwal97 uditagarwal97 changed the title [NFC] Refactor check_device_code/vector LIT tests [SYCL] Refactor check_device_code/vector LIT tests Feb 25, 2025
@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Feb 25, 2025 •
edited
Loading

@intel/llvm-gatekeepers the code formatter job is failing in undef deprecator because this PR added a test where LLVM IR uses undef. See llvm/llvm-project#118506

Running: git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 47630fea32e28d7b6f93f824876608b7f084737d aa16eb44e70b2cf82bbd2ed9f52fe8825b3d8420

sycl/test/check_device_code/vector/vector_as_preview.cpp
sycl/test/check_device_code/vector/vector_bf16_builtins_preview.cpp
sycl/test/check_device_code/vector/vector_convert_bfloat_preview.cpp
sycl/test/check_device_code/vector/vector_math_ops_preview.cpp
sycl/test/check_device_code/vector/vector_as.cpp
sycl/test/check_device_code/vector/vector_bf16_builtins.cpp
sycl/test/check_device_code/vector/vector_convert_bfloat.cpp
sycl/test/check_device_code/vector/vector_math_ops.cpp
error: undef deprecator failed

Do we have a BKM on how to handle such failures? Just ignore them or open a GH issue for front-end/middle-end team?

@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Feb 25, 2025

Do we have a BKM on how to handle such failures?

IMO, just merge.

@uditagarwal97
Copy link
Contributor Author

uditagarwal97 commented Feb 25, 2025

Failure in E2E test (HostInteropTask/interop-task-cuda-buffer-migrate.cpp) on CUDA in unrelated and reported here #17026
Skipping Windows E2E job - which failed earlier due to an infrastructure issue - as this PR only modifies Linux-only LIT tests.

@uditagarwal97 uditagarwal97 merged commit 3bd6b44 into intel:sycl Feb 25, 2025
17 of 20 checks passed
@uditagarwal97 uditagarwal97 mentioned this pull request Mar 6, 2025
Merged
@uditagarwal97 uditagarwal97 deleted the vec_lit_refac branch November 5, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees

@uditagarwal97 uditagarwal97

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uditagarwal97 @aelovikov-intel