From 9b38da413cfc5d317d1a5c9ded446dbbdb6a023b Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Mon, 7 Apr 2025 12:47:29 -0700 Subject: [PATCH 1/4] Disable asserts in sycl-linux-build by default --- .github/workflows/sycl-linux-build.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/sycl-linux-build.yml b/.github/workflows/sycl-linux-build.yml index d9a3ed3cf9cfb..a7c0f0249662a 100644 --- a/.github/workflows/sycl-linux-build.yml +++ b/.github/workflows/sycl-linux-build.yml @@ -32,6 +32,9 @@ on: build_artifact_suffix: type: string required: true + build_with_assertions: + type: string + default: false artifact_archive_name: type: string default: llvm_sycl.tar.zst @@ -170,6 +173,7 @@ jobs: python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \ -s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \ --ci-defaults ${{ inputs.build_configure_extra_args }} \ + ${{ !inputs.build_with_assertions == "true" ? "--no-assertions" | "" }} \ -DCMAKE_C_COMPILER_LAUNCHER=ccache \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ -DLLVM_INSTALL_UTILS=ON \ From 9cfc1650e812eb47fd0958eb6614ee1f498ac885 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Mon, 7 Apr 2025 12:57:29 -0700 Subject: [PATCH 2/4] Revert "Disable asserts in sycl-linux-build by default" This reverts commit 9b38da413cfc5d317d1a5c9ded446dbbdb6a023b. --- .github/workflows/sycl-linux-build.yml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/workflows/sycl-linux-build.yml b/.github/workflows/sycl-linux-build.yml index a7c0f0249662a..d9a3ed3cf9cfb 100644 --- a/.github/workflows/sycl-linux-build.yml +++ b/.github/workflows/sycl-linux-build.yml @@ -32,9 +32,6 @@ on: build_artifact_suffix: type: string required: true - build_with_assertions: - type: string - default: false artifact_archive_name: type: string default: llvm_sycl.tar.zst @@ -173,7 +170,6 @@ jobs: python3 $GITHUB_WORKSPACE/src/buildbot/configure.py -w $GITHUB_WORKSPACE \ -s $GITHUB_WORKSPACE/src -o $GITHUB_WORKSPACE/build -t Release \ --ci-defaults ${{ inputs.build_configure_extra_args }} \ - ${{ !inputs.build_with_assertions == "true" ? "--no-assertions" | "" }} \ -DCMAKE_C_COMPILER_LAUNCHER=ccache \ -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \ -DLLVM_INSTALL_UTILS=ON \ From 0b11964c0b903715e010a0ba0ab23f3e81334228 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Mon, 7 Apr 2025 13:58:41 -0700 Subject: [PATCH 3/4] Disable assertions for linux_shared_build --- .github/workflows/sycl-nightly.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sycl-nightly.yml b/.github/workflows/sycl-nightly.yml index 1ccf4a2498e6b..ca45ecfd422d8 100644 --- a/.github/workflows/sycl-nightly.yml +++ b/.github/workflows/sycl-nightly.yml @@ -15,7 +15,7 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - build_configure_extra_args: '--hip --cuda' + build_configure_extra_args: '--hip --cuda --no-assertions' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest retention-days: 90 @@ -23,6 +23,7 @@ jobs: # prefer widespread gzip compression. artifact_archive_name: sycl_linux.tar.gz + # Build used for performance testing only: not intended for testing linux_shared_build: if: github.repository == 'intel/llvm' uses: ./.github/workflows/sycl-linux-build.yml @@ -31,7 +32,7 @@ jobs: build_cache_root: "/__w/" build_cache_suffix: sprod_shared build_artifact_suffix: sprod_shared - build_configure_extra_args: '--shared-libs --hip --cuda --native_cpu' + build_configure_extra_args: '--shared-libs --hip --cuda --native_cpu --no-assertions' artifact_archive_name: sycl_linux_shared.tar.zst From fe414c3faf5c0a080708ba2a0d1708b35dc8a477 Mon Sep 17 00:00:00 2001 From: "Li, Ian" Date: Mon, 7 Apr 2025 14:05:22 -0700 Subject: [PATCH 4/4] Fix erroneous --no-assert --- .github/workflows/sycl-nightly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sycl-nightly.yml b/.github/workflows/sycl-nightly.yml index ca45ecfd422d8..47d76d4dd8c5e 100644 --- a/.github/workflows/sycl-nightly.yml +++ b/.github/workflows/sycl-nightly.yml @@ -15,7 +15,7 @@ jobs: with: build_cache_root: "/__w/" build_artifact_suffix: default - build_configure_extra_args: '--hip --cuda --no-assertions' + build_configure_extra_args: '--hip --cuda' build_image: ghcr.io/intel/llvm/ubuntu2204_build:latest retention-days: 90