[NFC][SYCL][Graph][Doc] Clarify aspect relationship #17996
Conversation
SYCL-Graph contains two aspects for reporting extension support. Make the relationship between the two aspects clearer to readers, as it wasn't immediately obvious to reviewers of a [application PR](ggml-org/llama.cpp#12873) using these aspects.
EwanC
changed the title
|
@intel/llvm-gatekeepers This is good to merge, there's a Jenkins precommit CI fail but this is a doc only patch. |
@EwanC the conclusion that if Jenkins/Precommit failed on doc-only patch, then everything is good - is not quite correct. We have a check in Jenkins/Precommit that executes on any text - including documentation. It is passed here. It is another check that failed which is really not related to documentation. I see this failure is CI-related and flaky, as it was passed on the recent PRs. So merging this PR. BTW, tag [Doc] is missing. |
dm-vodopyanov
changed the title
I retried the Jenkins/Precommit which is why it passed. |
I think there might be a misunderstanding. Do you mean the check which starts with letter |
|
When I first looked at this PR after gatekeepers were pinged I noticed the Jenkins/Precommit job had failed so I want to look at the logs, it was an infrastructure issue, so I restarted the pipeline and it passed. Between that happening and my returning to look at the results I think you came along and merged the PR. |
4 participants
SYCL-Graph contains two aspects for a device to report extension support. Make the relationship between the two aspects clearer to readers, as it wasn't immediately obvious to reviewers of an application PR using these aspects.