[SYCL][UR][L0 v2] implement OOO immediate queue #18903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xewar313
reviewed
Jun 11, 2025
Contributor
Xewar313
left a comment
Xewar313
left a comment
There was a problem hiding this comment.
Looks good, just two minor questions
unified-runtime/source/adapters/level_zero/v2/queue_immediate_out_of_order.cpp
Outdated
Show resolved
Hide resolved
pbalcer
reviewed
Jun 11, 2025
unified-runtime/source/adapters/level_zero/v2/queue_immediate_out_of_order.cpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/queue_immediate_out_of_order.cpp
Outdated
Show resolved
Hide resolved
EwanC
approved these changes
Jun 12, 2025
unified-runtime/source/adapters/level_zero/v2/queue_immediate_out_of_order.hpp
Outdated
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/queue_immediate_out_of_order.hpp
Show resolved
Hide resolved
unified-runtime/source/adapters/level_zero/v2/queue_immediate_out_of_order.cpp
Outdated
Show resolved
Hide resolved
pbalcer
reviewed
Jun 12, 2025
Contributor
maarquitos14
left a comment
maarquitos14
left a comment
There was a problem hiding this comment.
SYCL E2E changes LGTM.
maarquitos14
approved these changes
Jun 24, 2025
Contributor
Author
|
@intel/llvm-gatekeepers this is ready to be merged, the OPENCL issues are unrelated (fixed in: #19138) |
by using multiple in-order queues and round-robin strategy to dispatch work. With this approach we don't need to worry about events' lifetime. Since we are still using counter-based events, we don't need any special logic to handle cases where event release is called right after being passed as signal event or as part of a wait list.
Contributor
🚀 🚀 🚀 🚀 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using multiple in-order queues and round-robin
strategy to dispatch work.
With this approach we don't need to worry about events' lifetime. Since we are still using counter-based events, we don't need any special logic to handle cases where event release is called right after being passed as signal event or as part of a wait list.