[SYCL] Delete symbol based info with the last image referencing it #19659
+181
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, kernel name based info (e.g. kernel id or assert usage) was deleted whenever an image referencing it was removed. This is technically incorrect since multiple images can contain the same kernel name.
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
changed the title
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This reverts commit dcb4788.
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
sergey-semenov
changed the title
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -2140,44 +2155,67 @@ void ProgramManager::removeImages(sycl_device_binaries DeviceBinary) { | |||
| // Unmap the unique kernel IDs for the offload entries | |||
| for (sycl_offload_entry EntriesIt = EntriesB; EntriesIt != EntriesE; | |||
| EntriesIt = EntriesIt->Increment()) { | |||
|
|
|||
| const char *Name = EntriesIt->GetName(); | |||
There was a problem hiding this comment.
Can it be std::string_view instead?
There was a problem hiding this comment.
I changed it to detail::KernelNameStrT, which maps to std::string_view in preview builds and std::string otherwise, since there are a lot of containers involved that use this key type and don't have heterogenous lookup support.
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| m_KernelIDs2BinImage.erase(It->second); | ||
| m_KernelName2KernelIDs.erase(It); | ||
| auto Name2IDIt = m_KernelName2KernelIDs.find(Name); | ||
| if (Name2IDIt != m_KernelName2KernelIDs.end()) |
There was a problem hiding this comment.
When isn't that true?
There was a problem hiding this comment.
Nothing comes to mind, pretty sure this should be an assert. I'll make a follow up change for this.
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
sergey-semenov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, symbol based info (e.g. kernel id, kernel assert usage or images containing an exported symbol) was deleted whenever an image referencing it was removed. This is incorrect since multiple images can contain the same symbol.
While unlikely to cause any problems now (since those images usually all get removed with one call to
removeImagesafter another), this will cause issues once kernel name based kernel caches start getting cleaned up in the same manner.