- 
                Notifications
    You must be signed in to change notification settings 
- Fork 794
[CI] Move SPIRV-backend testing to post-commit #19669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Move SPIRV-backend testing to post-commit #19669
Conversation
490abfa    to
    20ace65      
    Compare
  
    20ace65    to
    0ee77dc      
    Compare
  
    0ee77dc    to
    fac3809      
    Compare
  
    fac3809    to
    0bc6a7b      
    Compare
  
    a5f090e    to
    bcc1e51      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I assumed this was already approved on behalf of llvm-reviewers-runtime
| Yeah sorry I'm not really a runtime team member so I usually re-add the team to reviews whenever my review is used for runtime, I'm in the group for CI/test reasons | 
| 
 No worries, that's my bad | 
| @reble , @intel/sycl-graphs-reviewers , ping. The change in the graphs tests is minimal and shouldn't take more than a few minutes to review. | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Apologies for the slow review.
| Windows failure is #19660, unrelated. | 
Fixes E2E test failure in `SeperateCompile/test.cpp` in sycl-rel 6.3 ABI testing(https://github.com/intel/llvm/actions/runs/18599730732/job/53035028308#step:27:2964) The test failure is because of lit using system-installed `sycl-post-link` instead of the newly built one. This PR forces lit to find and use tools from `<compiler build>/bin` directory. These changes are already in `sycl` branch (brought in by #19669)
Development happens mostly upstream, so there is no need to have that in pre-commit, post-commit should be enough.
Before this PR, when running E2E tests in "in-tree" mode (as opposite to a standalone e2e tests cmake invocation), some utilities (e.g.
llvm-ar) were only searched for inPATHthat didn't contain freshly built toolchain. Our pre-commit used a container image with last successful "Nightly" toolchain installed, so those were picked up from there. Post-commit uses GNU Compiler instead of Clang, so these utilities aren't available inPATH.This PR modifies
lit.cfg.pysuch that we search for those utilities in the newly built toolchain first (still not modifyingPATHwhich seems to be the approach taken in LIT). That also ensures thatopencl-aotfeature is available when running E2E tests inbuild-onlymode in Post-commit's build job.