[SYCL] Simplify check whether a header file is available for inclusion #19759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyniols
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dyniols
changed the title
dyniols
changed the title
group_interface extension
dyniols
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
While you're at it, could we apply the same to all other uses of defined(__has_include)? I see it in sycl/source/detail/os_util.cpp and sycl/include/syclcompat/kernel.hpp.
Contributor
Author
Sure |
dyniols
changed the title
group_interface extension
dyniols
changed the title
steffenlarsen
approved these changes
Aug 12, 2025
Contributor
Author
|
@intel/syclcompat-lib-reviewers Can you please review? |
dyniols
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
dyniols
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__has_includeis part of the C++ standard since C++17: https://en.cppreference.com/w/cpp/preprocessor/includeWe require C++17 if
sycl.hppis included, so we can use__has_includewithout extra checks for its presence.