From d4d5defeb70581ca285e2e02bd8bf68a49dbb6c5 Mon Sep 17 00:00:00 2001 From: Alexey Sachkov Date: Wed, 20 Aug 2025 10:10:37 +0200 Subject: [PATCH 1/2] Small rendering fixes --- .../sycl_ext_oneapi_bindless_images.asciidoc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc index 8a124ad549c69..f574984182d6c 100644 --- a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc +++ b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc @@ -226,8 +226,8 @@ semantics. [NOTE] ==== -Additional future `image_type`s _may_ include combined image types like -"mipmapped cubemap". +Additional future `image_type` enumerators _may_ include combined image types +like "mipmapped cubemap". ==== Note that `image_channel_type` and `image_channel_order` existed in SYCL 1.2.1, @@ -269,7 +269,7 @@ to query device support for the allocation and creation of images for a given Before allocating memory for an image, the user may first query whether their desired image backing memory type is supported by the device. -The following query returns a vector of supported `image_memory_handle_type`s +The following query returns a vector of supported `image_memory_handle_type` based on the properties of a given `image_descriptor`. The `image_memory_handle_type::usm_pointer` relates to USM allocations, while @@ -1387,7 +1387,7 @@ dimensions are `x` for 1D images, `x` and `y` for 2D images, and `x`, `y`, and `z` for 3D images. `x`, `y`, and `z` correspond to indices `0`, `1`, and `2` of the `SrcOffset` and `CopyExtent` parameters, respectively. -11. The `CopyExtent`'s' `x`, `y`, and `z` dimensions must not be `0`. They must +11. Dimensions `x`, `y`, and `z` of the `CopyExtent` must not be `0`. They must be greater than or equal to `1`. Even if the image is 1D or 2D, the remaining non-relevant dimension's values must be set to `1` in the `CopyExtent` parameter. @@ -2017,7 +2017,7 @@ The device aspect descriptors for these queries are: |Device descriptor |Description |`aspect::ext_oneapi_external_memory_import` | Indicates if the device supports importing external memory resources. -|`aspect::ext_oneapi_external_semaphore_import`` | Indicates if the device +|`aspect::ext_oneapi_external_semaphore_import` | Indicates if the device supports importing external semaphore resources. |====================== From 658ffb6911a3e05395f85379d1d915d89d49805d Mon Sep 17 00:00:00 2001 From: Alexey Sachkov Date: Wed, 20 Aug 2025 16:47:25 +0200 Subject: [PATCH 2/2] Swap sampled and descriptor arguments so that the spec matches the implementation --- .../sycl_ext_oneapi_bindless_images.asciidoc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc index f574984182d6c..0c6a8d27f5577 100644 --- a/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc +++ b/sycl/doc/extensions/experimental/sycl_ext_oneapi_bindless_images.asciidoc @@ -616,13 +616,13 @@ unsampled_image_handle create_image(image_mem_handle memHandle, // Creating a sampled image from an `image_mem_handle` sampled_image_handle create_image(image_mem_handle memHandle, - const image_descriptor &desc, const bindless_image_sampler &sampler, + const image_descriptor &desc, const sycl::device &syclDevice, const sycl::context &syclContext); sampled_image_handle create_image(image_mem_handle memHandle, - const image_descriptor &desc, const bindless_image_sampler &sampler, + const image_descriptor &desc, const sycl::queue &syclQueue); // Creating an unsampled image from an `image_mem` object @@ -636,24 +636,24 @@ unsampled_image_handle create_image(const image_mem &memHandle, // Creating a sampled image from an `image_mem` object sampled_image_handle create_image(const image_mem &memHandle, - const image_descriptor &desc, const bindless_image_sampler &sampler, + const image_descriptor &desc, const sycl::device &syclDevice, const sycl::context &syclContext); sampled_image_handle create_image(const image_mem &memHandle, - const image_descriptor &desc, const bindless_image_sampler &sampler, + const image_descriptor &desc, const sycl::queue &syclQueue); // Creating a sampled image from a USM allocation and pitch sampled_image_handle create_image(const void *usmPtr, size_t pitch, - const image_descriptor &desc, const bindless_image_sampler &sampler, + const image_descriptor &desc, const sycl::device &syclDevice, const sycl::context &syclContext); sampled_image_handle create_image(const void *usmPtr, size_t pitch, - const image_descriptor &desc, const bindless_image_sampler &sampler, + const image_descriptor &desc, const sycl::queue &syclQueue); // Destroying an image handle