[SYCL] Kernel submit wrapper functions for unit tests #19884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
LGTM, overall. Minor comments.
slawekptak
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
slawekptak
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Aug 28, 2025
Contributor
Author
|
@intel/llvm-gatekeepers Can you merge please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new kernel submit wrapper functions allow to select the submission function type between a standard handler-based function and queue shortcut function. This change allows to increase the test coverage and allows for testing no-handler submission path using existing unit tests.
This PR introduces the single_task submission function wrappers, and the use of the wrappers in a single unit tests set, but the goal is to extend the set of wrappers and their usage in unit tests, in the future.