Skip to content

[SYCL] Fix a stale handler_impl reference with reductions #19906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2025
Merged

[SYCL] Fix a stale handler_impl reference with reductions #19906

merged 2 commits into from
Aug 28, 2025

Conversation

@sergey-semenov
Copy link
Contributor

@sergey-semenov sergey-semenov commented Aug 27, 2025

No description provided.

@sergey-semenov sergey-semenov requested a review from a team as a code owner August 27, 2025 14:48
@sergey-semenov
Copy link
Contributor Author

sergey-semenov commented Aug 27, 2025 •
edited
Loading

@ianayl @aelovikov-intel @sarnex FYI

@sergey-semenov sergey-semenov changed the title [SYCL] Fix stale handler_impl reference issue with reductions [SYCL] Fix a stale handler_impl reference with reductions Aug 27, 2025
aelovikov-intel
aelovikov-intel approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, that was stupid of me... Thanks for fixing!

@ianayl ianayl mentioned this pull request Aug 27, 2025
Closed
@sergey-semenov
Copy link
Contributor Author

sergey-semenov commented Aug 28, 2025

Failures are unrelated and were seen on another PR:

Unexpectedly Passed Tests (1):
  SYCL :: Matrix/SG32/joint_matrix_bfloat16.cpp
On NVIDIA:
 Failed Tests (1):
  SYCL :: KernelCompiler/sycl_device_globals.cpp

@sergey-semenov sergey-semenov merged commit 0b01624 into intel:sycl Aug 28, 2025
28 of 31 checks passed
@sergey-semenov sergey-semenov mentioned this pull request Aug 28, 2025
Closed
AlexeySachkov pushed a commit to AlexeySachkov/llvm that referenced this pull request Sep 4, 2025
@sergey-semenov @AlexeySachkov
[SYCL] Fix a stale handler_impl reference with reductions (intel#19906)
c3c2a26
@AlexeySachkov AlexeySachkov mentioned this pull request Sep 4, 2025
Merged
AlexeySachkov added a commit that referenced this pull request Sep 8, 2025
@AlexeySachkov
[SYCL] Fix a stale handler_impl reference with reductions (#19975)
fb662f8 
This is a cherry-pick of #19906

Patch-by: Sergey Semenov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@againull againull Awaiting requested review from againull againull is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergey-semenov @aelovikov-intel