[NFC][SYCL] Update Graph E2E-tests #19928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are not intended to be launched.
KornevNikita
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
KornevNikita
commented
Aug 29, 2025
| // The OpenCL emulation layer does not return `CL_INVALID_WORK_GROUP_SIZE` as it | ||
| // should. So the Sycl graph support cannot correctly catch the error and throw | ||
| // the approriate exception for negative test. An issue has been reported | ||
| // https://github.com/bashbaug/SimpleOpenCLSamples/issues/95 |
Contributor
Author
There was a problem hiding this comment.
This issue was marked as resolved. Should this test be enabled?
Contributor
There was a problem hiding this comment.
Good catch. Same would apply to the Explicit test version above.
How about we enable both tests temporarily as a follow up PR, to see what the current status is?
Contributor
Author
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
@againull take a look please. Simple NFC change |
againull
approved these changes
Sep 3, 2025
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
KornevNikita
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
fail: #19965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are not intended to be launched.