Skip to content

[UR] better assertions #20169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2025
Merged

[UR] better assertions #20169

merged 3 commits into from
Sep 24, 2025

Conversation

@lslusarczyk
Copy link
Contributor

  • added printing backtrace to assertions
  • added debug and production assertions that break code immediately instead of throwing exception
  • asserting code immediately instead of throwing exception in debug mode for faster development
  • uninlining create_logger function
  • moved backtrace code from validation layer to common code

@lslusarczyk lslusarczyk requested review from a team as code owners September 23, 2025 13:24
slawekptak
slawekptak approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@slawekptak slawekptak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYCL changes LGTM

kswiecicki
kswiecicki reviewed Sep 23, 2025
View reviewed changes
@lslusarczyk
Copy link
Contributor Author

@intel/llvm-gatekeepers , please merge

@steffenlarsen steffenlarsen merged commit fc556a5 into intel:sycl Sep 24, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slawekptak slawekptak slawekptak approved these changes

@kswiecicki kswiecicki kswiecicki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lslusarczyk @slawekptak @kswiecicki @steffenlarsen