[NFC][SYCL] Minor includes cleanup #20178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to reduce compile-time for
```c+++
namespace oneapi = sycl::ext::oneapi;
extern "C"
SYCL_EXT_ONEAPI_FUNCTION_PROPERTY((oneapi::experimental::nd_range_kernel<1>))
void iota(float start, float *ptr) {
size_t id = oneapi::this_work_item::get_nd_item<1>().get_global_linear_id();
ptr[id] = start + static_cast<float>(id);
}
```
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
commented
Sep 23, 2025
| #define __SYCL_ASSERT(x) assert(x) | ||
| #endif // #ifdef __SYCL_DEVICE_ONLY__ | ||
|
|
||
| #define __SYCL_UR_ERROR_REPORT(backend) \ |
There was a problem hiding this comment.
Only used under sycl/source, so moved there.
aelovikov-intel
commented
Sep 23, 2025
| #include <sycl/ext/oneapi/properties/property_utils.hpp> // for Sorted, Mer... | ||
| #include <sycl/ext/oneapi/properties/property_value.hpp> // for property_value | ||
|
|
||
| #include <tuple> // for tuple, tupl... |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to reduce compile-time for