[SYCL][Graph] Add E2E test for recording handlerless queue submissions #20420
+119
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mmichel11
commented
Oct 21, 2025
mmichel11
commented
- Follow-up test case to the bug fixed in [SYCL] Update the kernel function pointer on function copy/move #20389 which was not caught by SYCL graph tests.
- Exercises graph recording over queue submissions with handlerless APIs. Queue submissions are recorded over a non-inlined function call to provide coverage over now resolved kernel argument capture issues.
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mmichel11
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Removed the handlerless ops not supported with command buffers in the OpenCL adapter (prefetch, memadvise), so we can still test this configuration. |
slawekptak
approved these changes
Oct 22, 2025
reble
reviewed
Oct 22, 2025
Comment on lines
12
to
17
| #include "../graph_common.hpp" | ||
| #include <cstdint> | ||
| #include <cstring> | ||
| #include <sycl/ext/oneapi/experimental/enqueue_functions.hpp> | ||
| #include <sycl/properties/all_properties.hpp> | ||
| #include <vector> |
There was a problem hiding this comment.
This looks quite verbose to other related tests. Can you please check if includes are actually required, if so we might want to update graph_common.hpp ...
There was a problem hiding this comment.
The vector, stdint, and string includes are not necessary, so I removd them. enqueue_functions.hpp and all_properties.hpp are required here but not used across all tests, so I didn't add them to graph_common.hpp.
If we'd rather just have any needed includes in graph_common.hpp, then I can move those there.
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mmichel11
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.